Commit graph

2855 commits

Author SHA1 Message Date
Hrvoje Jasak
16b9d2b796 Comment 2019-06-26 17:16:54 +01:00
Hrvoje Jasak
19890cb253 Added fallthrough attribute 2019-06-19 11:38:43 +01:00
Hrvoje Jasak
d4f21693fa Change Immersed Boundary dead cell handling in matrix: boost diagonal and setValues 2019-06-19 11:23:18 +01:00
Hrvoje Jasak
6c80a5b3e4 fixedGradient writes value - avoid duplicate write 2019-06-18 14:59:11 +01:00
Hrvoje Jasak
31ea91e35b Rewrite of wall function boundary conditions to support immersed boundary wall functions. Incompressible fixes; extended to compressible 2019-06-18 12:48:16 +01:00
Hrvoje Jasak
cffe702f75 Use labelField for refinement history to allow for parallel decomposition and reconstruction + load balancing 2019-06-18 12:47:16 +01:00
Hrvoje Jasak
94af00fa04 Splitting immersed boundary turbulence libraries to incompressible and compressible; Added compressible wall functions 2019-06-18 12:46:03 +01:00
Hrvoje Jasak
624b6a72b8 Rewrite of parallel gather-write of immersed boundary patch data 2019-06-17 18:16:26 +01:00
Hrvoje Jasak
328c75a101 Refactoring for immersed boundary support 2019-06-17 15:37:54 +01:00
Hrvoje Jasak
1fd5416dfc Fixed read and mapping errors on turbulence boundary conditions 2019-06-17 11:11:49 +01:00
Hrvoje Jasak
7334b895fe Style changes: FatalError 2019-06-17 11:10:35 +01:00
Vuko Vukcevic
07c16f1454 Updates to oversetMesh include files 2019-06-13 11:14:49 +02:00
Vuko Vukcevic
ce6f4f6473 Update in fvcReconstruct to enable hinv
Reconstruction equation reformulated in a way such that the inverse is always
calculated for a dimensionless dyadic tensor (Sf*Sf/magSf^2) instead of one that
scales with magSf (Sf*Sf/magSf). This proved to be problematic when we had
extremely small cells which triggered the calculation of inverse using
Householder's method.
2019-06-13 11:10:32 +02:00
Vuko Vukcevic
43080d7042 Fixed typos in comments 2019-06-13 11:07:18 +02:00
Hrvoje Jasak
070957cff2 Revert hinv in fvcReconstruct - problem cases. 2019-06-09 21:41:57 +01:00
Hrvoje Jasak
b2c5b1f561 Make pointLevel and cellLevel labelIOField for consistency 2019-06-02 19:24:13 +01:00
Vuko Vukcevic
860a681c8b Another orEqOp bugfix in the nLayers loop 2019-05-27 11:23:28 +02:00
Vuko Vukcevic
f6b3e9932b Bugfixes in cuttingPatchFringe
1. Marking cut hole cells as inside cells,
2. Parallel bugfix when syncing mark-up field across faces: used orOp instead of
   orEqOp for combination.
2019-05-27 10:37:49 +02:00
Vuko Vukcevic
8051a31239 Refactorization of cuttingPatchFringe 2019-05-22 12:08:44 +02:00
Vuko Vukcevic
7631b1d9db Additional sanity check for duplicate connected regions 2019-05-21 09:26:02 +02:00
Vuko Vukcevic
a9c1ebfe3d Bugfixes in cuttingPatchFringe
1. No need to flip the face when creating .stl
2. Removed wrong break statement
3. Slight reorganization and improvements
2019-05-20 16:50:25 +02:00
Vuko Vukcevic
127741a4a9 First version of cuttingPatchFringe algorithm
Similar to donorBasedOverlapFringe but better in a sense that it relies on
determining inside/outside region by creating an STL of the patch from donor
region. Note: still has bugs
2019-05-20 16:16:13 +02:00
Vuko Vukcevic
2ac52835c6 Minor update to faceCells' fringe interface 2019-05-20 16:15:51 +02:00
Vuko Vukcevic
f041b8e746 Minor updates to oversetCourantNo.H and oversetAlphaCourantNo.H
Just to make it more self-sustainable
2019-05-20 09:21:22 +02:00
Vuko Vukcevic
189078e98e Post processing updates to Overset Mesh
oversetMesh::regionIDPtr_ is now a pointer to volScalarField instead of
labelField in order to allow automatic I/O for post processing.
2019-05-20 08:57:29 +02:00
Vuko Vukcevic
7b4ec99683 Parallel bugfixes in donorBasedLayeredOverlapFringe 2019-05-20 08:57:29 +02:00
Vuko Vukcevic
9a178ce555 Work in progress regarding parallel bugfix in donorBasedLayeredOverlapFringe 2019-05-20 08:57:29 +02:00
Vuko Vukcevic
6f532eee4f Minor formatting 2019-05-20 08:57:29 +02:00
Vuko Vukcevic
9e1470a06d Robustness improvement in donorBasedLayeredOverlapFringe
Looking at bounding box of the connected region to determine whether we are
going in the right direction.
2019-05-20 08:57:29 +02:00
Vuko Vukcevic
0590d254e0 Run-time bugfixes in donorBasedLayeredOverlapFringe
Note: still need to thoroughly test in parallel and with multiple donor regions
for a single background region
2019-05-20 08:57:29 +02:00
Vuko Vukcevic
ba114c1b5d Version of donorBasedOverlapFringe that compiles
Note: still not tested
2019-05-20 08:57:29 +02:00
Vuko Vukcevic
6a5117ed51 Finished writing first version of donorBasedLayeredOverlap fringe
Note: did not attempt to compile yet, let alone test it
2019-05-20 08:57:29 +02:00
Vuko Vukcevic
31019383d2 Temporary commit
donorBasedLayeredOverlap fringe algorithm. Work in progress.
2019-05-20 08:57:29 +02:00
Hrvoje Jasak
b6c9f0c577 Tow-stage Immersed face tolerance consistency. QUick reject using shortest face in edge and detailed analysis edge-by-edge. Inno Gatin 2019-05-15 13:02:15 +01:00
Hrvoje Jasak
6c9291cd4e Immersed face tolerance consistency. Inno Gatin 2019-05-15 09:42:05 +01:00
Hrvoje Jasak
a4d077f45b Formatting 2019-05-13 11:48:26 +01:00
Hrvoje Jasak
494ffcff89 Porting: single precision requires casting in max 2019-05-10 14:27:58 +01:00
Hrvoje Jasak
8a64613197 Reverting debug change: file based communication replaced by Pstream. 2019-05-08 11:48:51 +01:00
Hrvoje Jasak
7ef4377a9c Improved normalisation of reported residuals for block-coupled systems 2019-05-02 13:29:21 +01:00
Hrvoje Jasak
93849cea09 Bugfix: decomposeMesh offset. Vuko Vukcevic 2019-05-01 17:19:53 +01:00
Hrvoje Jasak
3214174c2c Removed templated NamedEnum::names instantiation: always in specialisations 2019-05-01 13:58:24 +01:00
Hrvoje Jasak
d2c6d4e489 Merge branch 'nextRelease' of ssh://git.code.sf.net/p/foam-extend/foam-extend-4.0 into nextRelease 2019-05-01 13:56:13 +02:00
Hrvoje Jasak
b71851619f Porting: Clean up of initialisation of static data, casting and comparison with enum, Mac OSX 2019-05-01 13:55:18 +02:00
Hrvoje Jasak
1817de53ad BUGFIX: View factor smoothing now takes into account reciprocity condition 2019-05-01 09:41:55 +01:00
Hrvoje Jasak
076919ae55 Bugfix: call to completeAssembly in wrong place. Henrik Rusche 2019-05-01 09:40:29 +01:00
Hrvoje Jasak
267fa0eba8 Merge branch 'nextRelease' of ssh://git.code.sf.net/p/foam-extend/foam-extend-4.0 into nextRelease 2019-04-30 16:59:25 +02:00
Hrvoje Jasak
884667e262 Merge branch 'nextRelease' of ssh://git.code.sf.net/p/foam-extend/foam-extend-4.0 into nextRelease 2019-04-30 15:45:37 +01:00
Hrvoje Jasak
ef519cd839 Porting: typed label bug fix. Daniel Khazaei 2019-04-30 15:44:41 +01:00
Hrvoje Jasak
f97c0f81ab Updated I/O handling of fixed gradient and mixed FV patches for DLB. Vuko Vukcevic 2019-04-30 15:44:09 +01:00
Hrvoje Jasak
e63cc43dfa Reverting unnecessary DLB change by HR 2019-04-30 15:43:38 +01:00
Hrvoje Jasak
b1e3690002 Fixed fallthrough attribute 2019-04-30 15:43:01 +01:00
Hrvoje Jasak
2d799c2cdf Bugfix: bad addressing in analysis of coupled boundar IBM cut 2019-04-30 15:07:08 +01:00
Henrik Rusche
70ed6ba967 BUGFIX: View factor smoothing now takes into account reciprocity condition 2019-04-25 18:39:16 +02:00
Hrvoje Jasak
785fbd9c25 Merge branch 'nextRelease' of ssh://git.code.sf.net/p/foam-extend/foam-extend-4.0 into nextRelease 2019-04-25 15:05:32 +02:00
Hrvoje Jasak
78276e48af Porting: strip register keyword 2019-04-25 14:00:49 +01:00
Hrvoje Jasak
9eac282022 Revert change in Make/files 2019-04-25 13:58:15 +01:00
Hrvoje Jasak
83d768ad9a Pstream::commsTypes fix script change error 2019-04-25 13:52:15 +01:00
Hrvoje Jasak
b08982a4d0 Merge branch 'nextRelease' of ssh://git.code.sf.net/p/foam-extend/foam-extend-4.0 into nextRelease 2019-04-25 12:18:30 +02:00
Hrvoje Jasak
109b8456d8 Merge of friend function declaration 2019-04-25 11:12:34 +01:00
Hrvoje Jasak
84121da55f Merge branch 'nextRelease' of ssh://git.code.sf.net/p/foam-extend/foam-extend-4.0 into nextRelease 2019-04-25 11:09:35 +01:00
Hrvoje Jasak
f538892f93 Porting: Mac OSX scoping of Pstream 2019-04-25 11:04:41 +01:00
Hrvoje Jasak
cf061271af Merge branch 'nextRelease' of ssh://git.code.sf.net/p/foam-extend/foam-extend-4.0 into nextRelease 2019-04-19 11:22:56 +02:00
Hrvoje Jasak
aefefb78d9 mall update to solutionControl's interface. Vuko Vukcevic 2019-04-09 12:01:28 +01:00
Hrvoje Jasak
71a25fc3c3 Bugfixes and improvements in DLB and AMR. Vuko Vukcevic 2019-04-09 12:00:24 +01:00
Hrvoje Jasak
ca3b76f412 gcc8 compliance improvments. Danial Khazaei 2019-04-09 11:50:59 +01:00
Hrvoje Jasak
67ee1222b5 Bugfix: return scalar instead of truncated label. Daniel Khazaei. 2019-04-09 11:46:48 +01:00
Hrvoje Jasak
6a466c4378 Adjust IBM cut tolerances 2019-04-05 15:33:40 +01:00
Hrvoje Jasak
2bd012729b Bugfix: live factor rejection by cells ; not by faces 2019-04-05 15:33:15 +01:00
Hrvoje Jasak
9bdc8ce728 Multiple bug fixes: wet-on-cut faces must be wet; iteration in cut; consistent cut on processor boundary; adjust cut for 2-D geometries in case STL is not normal; report zero area IBM face 2019-04-05 15:31:52 +01:00
Hrvoje Jasak
39501b9254 Comment 2019-04-05 15:28:41 +01:00
Hrvoje Jasak
f8f6b78897 Added info on volume change in mesh motion 2019-04-03 13:05:34 +01:00
Hrvoje Jasak
6071684d0f Merge branch 'nextRelease' of ssh://git.code.sf.net/p/foam-extend/foam-extend-4.0 into nextRelease 2019-03-30 10:44:19 +00:00
Hrvoje Jasak
4d6f8b5bec Better report on volume change 2019-03-29 21:51:08 +00:00
Hrvoje Jasak
686c7a20ed Formatting 2019-03-29 15:08:02 +00:00
Vuko Vukcevic
038f60dc73 Slight update to solutionControl interface
Changed time and under-relaxation consistency members from private to protected
2019-03-28 17:28:08 +01:00
Hrvoje Jasak
eeefdf7552 Comment on IB patch normal 2019-03-28 15:49:47 +00:00
Hrvoje Jasak
63bd3ed52b Bugfix: Use Sf normal rather than n in moving immersed boundary: they are not parallel due to Marooney maneouvre 2019-03-28 15:49:14 +00:00
Hrvoje Jasak
8207c9cd62 Do not write phi in immersedBoundaryFvsPatchField 2019-03-28 15:48:35 +00:00
Hrvoje Jasak
1ce46b1f08 Reset field to zero if size is updated 2019-03-28 15:09:12 +00:00
Hrvoje Jasak
6c2263a2bf Tight tolerances on mesh motion error 2019-03-27 18:12:22 +00:00
Hrvoje Jasak
62228e7189 Reduced immersed boundary cutting tolerances 2019-03-22 13:34:00 +00:00
Hrvoje Jasak
24043c0817 Added virtual functions; removed looks in boundary FV data updates for IB patch 2019-03-22 13:33:07 +00:00
Hrvoje Jasak
60fa49504f Calculate Co number only on large live faces 2019-03-22 13:31:02 +00:00
Hrvoje Jasak
b7dffa272f Added virtual nf function directly from cut patch 2019-03-22 13:30:58 +00:00
Hrvoje Jasak
ec3b5f5574 Robustness: use hinv in fvcReconstruct to deal with cases of zero determinant 2019-03-22 13:26:21 +00:00
Hrvoje Jasak
f75b75df7b Make nf function virtual: better accuract for immersed boundary 2019-03-22 13:25:48 +00:00
Hrvoje Jasak
7ea4631c84 Stability fix: hinv inverse of truly singular tensors 2019-03-22 11:49:53 +00:00
Hrvoje Jasak
7fc1abd4b7 Added wet surface check for dry face 2019-03-15 10:47:56 +00:00
Hrvoje Jasak
85e0d4f65e Improbed Marooney Maneouvre debug message 2019-03-15 10:46:57 +00:00
Hrvoje Jasak
6fe4ba3aa3 Immersed boundary robustness improvements 2019-03-13 12:19:27 +00:00
Vuko Vukcevic
ac71ae4d16 Added a few comments regarding recent bugfixes 2019-03-08 12:51:33 +01:00
Vuko Vukcevic
d1116b86a9 Temporary change in refinement.C regarding edge consistency
Removed FatalError and instead issuing a warning (if debug) for runs with
Parallel Load Balancing. Still need to test thoroughly
2019-02-20 13:54:16 +01:00
Vuko Vukcevic
cea60ab8ab Refactorisation in refinement polyMeshModifier
Moved extendMarkedCellsAcrossFaces and extendMarkedCellsAcrossPoints from
refinement to meshTools.
2019-02-20 12:55:06 +01:00
Vuko Vukcevic
0efa19e651 Wrapped DLB output around if (debug) 2019-02-20 12:06:25 +01:00
Vuko Vukcevic
7f08269ab2 Two bugfixes:
1. polyTopoChanger::changeMesh -> call to polyTopoChanger::update needs to
   happen after polyMesh::updateMesh (more specifically,
   polyBoundaryMesh::updateMesh) in order to correctly build the processor data,
2. refinement::updateMesh -> now that number 1 is fixed, point sync happens in
   updateMesh instead of setRefinement.

These two combined were responsible for hard-to-track errors in AMR + DLB
2019-02-19 22:15:16 +01:00
Vuko Vukcevic
5526c3a048 Updated comment for member function 2019-02-19 21:59:45 +01:00
Vuko Vukcevic
bb23c4851d Bugfix on debug
When issuing a Warning, don't raise FatalError
2019-02-18 13:04:44 +01:00
Vuko Vukcevic
3742439d0f Bugfix in prismatic2DRefinement
Mistakenly used patch.size() instead of patch.start() to fetch the global face
index. This caused points at the boundary to be marked as split points, which is
not allowed. Also corrected a few typos.
2019-02-17 12:01:18 +01:00
Vuko Vukcevic
712807e126 Removed temporary debug stuff from polyhedralRefinement 2019-02-17 10:01:18 +01:00
Vuko Vukcevic
33c4eb5986 Minor formatting and debug output 2019-02-17 10:00:41 +01:00
Vuko Vukcevic
9871df3d78 Added minimum protected level to protectedInitialRefinement 2019-02-17 09:59:35 +01:00
Vuko Vukcevic
46756467b4 Improvement in globalProcFaceIndex
globalProcFaceIndex::globalLabel returns a reference and not a copy
2019-02-17 00:34:17 +01:00
Vuko Vukcevic
028cafdb32 Slight refactorisation in processorMeshesReconstructor::reconstructMesh 2019-02-17 00:32:00 +01:00
Vuko Vukcevic
f1c714eabf Upper-triangular neighbour ordering PLB bugfix
In PLB, the upper-triangular error (for neighbours of a given owner) was
appearing because the faces merged from two processor patches into an internal
face were not ordered correctly. This is now fixed by sorting out these faces
when doing the decomposition.
2019-02-17 00:29:14 +01:00
Danial Khazaei
e8a0078301
[bugfix]: 64-bit label bugfix some how got overwritten by cfMesh update. 2019-02-16 02:21:29 +03:30
Danial Khazaei
7fee1a978c
[cxx-syntax]: consistent usage of nullptr. 2019-02-16 00:22:28 +03:30
Danial Khazaei
c429f3b275
[bugfix]: recover velocity field in a more general way.
avoiding compilation failure in e.g. waves2Foam
2019-02-15 23:19:15 +03:30
Danial Khazaei
be47d0ece1
[format]: make forward declaration style consistent. 2019-02-15 23:12:44 +03:30
Danial Khazaei
0642eb7c4a
[bugfix]: friend operators need forward declaration to avoid gcc warning.
Without forward declaration, gcc warns that the operator has not been declared
within foam but only as a friend.
2019-02-15 22:30:51 +03:30
Hrvoje Jasak
1c6c10d84a Fixed merge failure 2019-02-13 18:06:23 +00:00
Hrvoje Jasak
2fea87c674 Bugfix and improvement in interpolateXY function that returns a field. Vuko Vukcevic 2019-02-13 15:51:10 +00:00
Hrvoje Jasak
0dc478ae7b Wrong dimensions on creation of zero geometric field. Vuko Vukcevic 2019-02-13 15:48:26 +00:00
Hrvoje Jasak
ac82db9f2d Incorrect base class method override in sixDoFRigidBodyDisplacementPointPatchVectorField. Dario Zivkovic 2019-02-13 15:46:14 +00:00
Hrvoje Jasak
9c8f3f6649 Minor fixes: postfixedSubRegistry and non-contiguous lists indentation. Henrik Rusche 2019-02-13 15:42:47 +00:00
Hrvoje Jasak
e2189947db Resolving merge commits 2019-02-13 15:41:35 +00:00
Hrvoje Jasak
37c728edfb Bugfix: nullptr 2019-02-13 15:38:37 +00:00
Hrvoje Jasak
b07ee20154 Improvement in protectedInitialRefinement. Author: Vuko Vukcevic 2019-02-13 15:27:57 +00:00
Hrvoje Jasak
4311ba296a GCC8 compatibility improvements. Cumulative improvment on gcc8 compliance. Added support for openmpi version 4.0.0 Updated cfMesh library to latest version. Author: Danial Khazaei 2019-02-13 15:25:42 +00:00
Hrvoje Jasak
396997c0ae BUGFIX: Compile WM_LABEL_SIZE=64 (final). Author: Henrik Rusche. 2019-02-13 15:17:29 +00:00
Hrvoje Jasak
9b5826bf88 Merge branch 'nextRelease' of ssh://git.code.sf.net/p/foam-extend/foam-extend-4.0 into nextRelease 2019-02-13 14:38:06 +00:00
Hrvoje Jasak
e7fff4e89c Reorder constructors 2019-02-13 14:35:45 +00:00
Hrvoje Jasak
76d57ed7fd Added syncPar switch to enable/disable parallel comms in polyMesh 2019-02-13 14:35:33 +00:00
Danial Khazaei
d2bc2468c7
format: make cfMesh banner consistent and removed trailing whitespace 2019-02-05 07:38:23 +03:30
Henrik Rusche
f000c7f6b8 List<label> -> labelList and simiar throughout 2019-02-04 21:58:51 +01:00
Henrik Rusche
951ca591e8 Fixes to avoid changing the operators in the control switches 2019-02-04 21:58:51 +01:00
Henrik Rusche
923fee738e BUGFIX: Compile WM_LABEL_SIZE=64 2019-02-04 21:58:51 +01:00
Vuko Vukcevic
11acc2de1d Temporary commit: intermediate refactorisation stage 2019-02-03 16:46:49 +01:00
Vuko Vukcevic
21154aa132 Temporary bugfix in decomposeMesh
Needs clean-up and refactorization
2019-02-01 09:43:40 +01:00
Danial Khazaei
5f08a2f90a
Bugfix: update cfMesh to v1.1 which fixes self-comparison always evaluates to false [-Wtautological-compare] 2019-01-31 17:52:39 +03:30
Danial Khazaei
0803bdbe20
Bugfix: fixed the compiler can assume that the address of ‘t’ will never be NULL warning [-Waddress] 2019-01-31 17:33:45 +03:30
Danial Khazaei
a480f9577c
Bugfix: type qualifiers ignored on cast result type 2019-01-31 17:16:18 +03:30
Danial Khazaei
23ef4e1dc3
Bugfix: overflow in conversion from Foam::label to int 2019-01-31 17:11:22 +03:30
Hrvoje Jasak
e1837adbf8 Cumulative development and fixes. Vuko Vukcevic. 2019-01-30 14:46:17 +00:00
Hrvoje Jasak
b3b16d1cc8 Layered overlap fringe strategy. Author: Vuko Vukcevic. Merge: Hrvoje Jasak. 2019-01-30 14:38:37 +00:00
Hrvoje Jasak
a031ca8136 Bugfix: Fixed missing dependency in Windows compilation. Henrik Rusche 2019-01-30 14:23:33 +00:00
Hrvoje Jasak
67e2f83134 Bugfix: resolving read problem in initialisation of IB patch fields 2019-01-29 09:53:30 +00:00
Hrvoje Jasak
758dad7a27 IB patch sizing trick deactivated 2019-01-26 13:19:35 +00:00
Hrvoje Jasak
01ae864020 remaining nullptr 2019-01-25 16:25:13 +00:00
Hrvoje Jasak
c6babd359a Update to c++-11 standard: nullptr and compilation flags 2019-01-25 16:22:44 +00:00
Hrvoje Jasak
0da8433b5d Delayed initialisation of the immersed boundary patch: avoid cutting at patchField initialisation and delay until fvMesh init 2019-01-25 16:16:16 +00:00
Hrvoje Jasak
17632aaa21 Parallelism and robustness improvements. Inno Gatin 2019-01-25 16:14:35 +00:00
Vuko Vukcevic
957235997b Bugfix in AMR related to PLB
Allow 2:1 face consistency on possibly newly created processor faces.
2019-01-25 10:26:08 +01:00
Vuko Vukcevic
920ff7bcc4 Manually merged Henrik's DLB and some other stuff 2019-01-23 13:03:44 +01:00
Vuko Vukcevic
0f73d80cf0 Added minimum protected level to protectedInitialRefinement 2019-01-23 09:39:20 +01:00
Vuko Vukcevic
abc4f08028 Bugfix in dimensions
steadyStateDdtScheme::fvcDdtConsistentPhiCorr returns a zero field with wrong
dimensions (need to multiply with rAU dimensions instead of dividing).
Reported by InSu Lee, Seoul National University.
2019-01-15 12:15:39 +01:00
Henrik Rusche
a18d10c0aa BUGFIX: new inletOutlet breaks with postfixedSubRegistry 2019-01-03 17:01:32 +01:00
Henrik Rusche
e114bb940d STYLE: Enable indentation for short non-contiguous lists 2018-12-30 16:06:11 +01:00
Dario Zivkovic
d40386d529 Make sixDoF's rmap override PointPatchFieldTemplate base class method 2018-12-24 14:49:22 +01:00
Vuko Vukcevic
75d5b4a289 Bugfix in pointPatchInterpolate
Regarding boundary condition update for non coupled boundaries of point
fields, take 2 (my mistake: Vuko Vukcevic)
Author: Dario Zivkovic.
2018-12-21 19:26:11 +01:00
Vuko Vukcevic
2afc0297bc Added access function to polyMeshGen in cartesianMeshGenerator 2018-12-12 16:16:31 +01:00