- Previously, Spack didn't check the arguments you put in version()
directives.
- So, you could do something like this, where there are arguments for a
URL fetcher AND for a git fetcher:
version('1.0', md5='abc123', git='https://foo.bar', commit='feda2343')
- Now, we check the arguments before constructing a fetcher, to ensure
that each package has *only* arguments for a single type of fetcher.
- Also added `test_package_version_consistency()` to the `package_sanity`
test, so that all builtin packages are required to have valid
`version()` directives.
- packagers can specify two top-level fetch URLs if one is `url`
- e.g., `url` and `git` or `url` and `svn`
- allow only one VCS fetcher so we can differentiate between URL and VCS.
- also clean up fetcher logic and class structure
- Packages can remove the top-level `url` attribute and still work
- These are now legal:
- Packages with *only* version-specific URLs (even with gaps)
- Packages with a top-level git/hg/svn attribute and `version`
directives for that.
- If a package has both a top-level hg/git/svn attribute AND a top-level
url attribute, the url attribute takes precedence.
Some packages do not have a `url` and are instead downloaded via `git`,
`hg`, or `svn`. Some packages like `spectrum-mpi` cannot be downloaded at
all, and are placeholder packages for system installations. Previously,
`__init__()` in `PackageBase` crashed if a package did not have a `url`
attribute defined.
I hacked this section of code out, but I have no idea what the
repercussions of that are.
- This hard-codes the hash lengths rather than computing them on import.
- Also cleans up the code in `spack.util.crypto` to make it easier to
understand.
Fix this output error:
```
$ spack -m module loads mpileaks
==> Error: `spack module loads -m t -m c -m l ...` has been moved. Try this instead:
$ spack module t loads mpileaks
$ spack module c loads mpileaks
$ spack module l loads mpileaks
```
In case a deprecated form of the module command is used, the program
will exit non-zero and print an informative error message suggesting
which command should be used instead.
As requested in the review all the commands meant to manage module
files have been grouped under the `spack module` command.
Unit tests have been refactored to match the new command structure.
fixes#2215fixes#2570fixes#6676fixes#7281closes#3827
This PR reverts the use of `spack module loads` in favor of
`spack module find` when loading module files via Spack. After this PR
`spack load` will accept a single spec at a time, and will be able
to interpret correctly the `--dependencies` option.
fixes#4400
The feature requested in #4400 was already part of the module file
configuration, but it was neither tested nor documented. This
commit takes care of adding a few lines in the documentation and a
regression test.
This just because the fixture has been moved one level above the one
it was originally defined. In this more general context there's more
than one configuration file that could be patched for tests.
'spack module' has been split into multiple commands, each one tied to a
specific module type. This permits the specialization of the new
commands with features that are module type specific (e.g. set the
default module file in lmod when multiple versions of the same package
are installed at the same time).
- repo membership test was broken by the refactor of spack/__init__.py
- refactor singleton so that 'spec in repo' works again for `spack.repo.path`
- fix spec command and add basic tests for `spack spec` and `spack spec --yaml`
* Test Spack on Python 3.7 as part of Travis CI
* Currently using xenial to pull-in python 3.7
* As xenial is not officially supported yet, Travis tolerates failures on it.
- There was a lot of documentation in `PackageBase` dating back to the
very first versions of Spack.
- It was repetitive and out of date, and the docs at spack.readthedocs.io
are better.
- Remove the outdated specifics, and leave the minimal useful set of
developer docs in `package.py`.
- This changes `get_checksums_for_versions` to generate code that uses an
explicit `sha256` argument instead if the bare `md5` hash we used to
generate.
- also use a generic digest parameter for the `version` directive, rather
than a specific `md5` parameter.
- Frequently, the documentation build will fail mysteriously in some
spack command.
- The cause is some new bug introduced by the PR, but this is not
apparent because the unit tests haven't run and the doc tests aren't
targeted at code bugs.
- Users end up puzzled by doc failures when they're really code failures.
- Move the doc tests parallel with the code tests, so that we can more
easily see bugs like this.
* fix to build libmatheval with guile@2.0:
* fixed formatting issues
* fixed formatting issues2
* fixed check for autoreconf and renaming of configure.in
* fixed force_autoreconf
* now patching configure, which is hopefully more robust
* minimal patches for guile 2.0 and 2.2 (disabeling unit testing for libmatheval)
* minimal patches for guile 2.0 and 2.2 (disabeling unit testing for libmatheval)
* add mofem-cephas package
* add mofem fracture module
* add user modules build and fracture modyle
* add minimal surface module
* add slepc variant
* bump mofem core lib version
* bump mofem core lib version
* bump version
* fix bug
* set upper bound to petsc version and other chanes
* fix indentation
* add minimal med file installation
* chcekc with flake8 and installation with spack packages
* add variants to med package
* upper bound to adol-c and remove obsolete internal package install
* fix basic module install
* module install from external source in extended prefix
* remove obsolte code and reverse to variant doxygen
* fix git adress
* improve packaging for mofem users modules
* fix flake8
* move dependencies after variants
* move root_cmakelists_dir right before cmake_args
* remove unused variants
* use append for single element
* replace root_cmakelists_dir
* use install_tree instead copy tree
* simplify code
* remove phase and mkdirp
* add run tests
* instal ext modules to ext_users_modules directory
* move version below url
* simplify directory name
* use underscore in variant name
* remove unused variable
* fix link to blas libs
* add missing boost dependence
* fix problem with copying module source code
* change variant name form doxygen to docs
* add expanded description
* make installation consistent with spack
* fix flake8
* make extensions installed
* code comments and minor corrections
* make slepc variant false by default
- Add command-line scope option to Spack
- Rework structure of main to allow configuration system to raise
errors more naturally
Co-authored-by: Todd Gamblin <tgamblin@llnl.gov>
