Commit graph

4996 commits

Author SHA1 Message Date
Hrvoje Jasak
aefefb78d9 mall update to solutionControl's interface. Vuko Vukcevic 2019-04-09 12:01:28 +01:00
Hrvoje Jasak
71a25fc3c3 Bugfixes and improvements in DLB and AMR. Vuko Vukcevic 2019-04-09 12:00:24 +01:00
Hrvoje Jasak
ca3b76f412 gcc8 compliance improvments. Danial Khazaei 2019-04-09 11:50:59 +01:00
Hrvoje Jasak
67ee1222b5 Bugfix: return scalar instead of truncated label. Daniel Khazaei. 2019-04-09 11:46:48 +01:00
Hrvoje Jasak
6a466c4378 Adjust IBM cut tolerances 2019-04-05 15:33:40 +01:00
Hrvoje Jasak
2bd012729b Bugfix: live factor rejection by cells ; not by faces 2019-04-05 15:33:15 +01:00
Hrvoje Jasak
9bdc8ce728 Multiple bug fixes: wet-on-cut faces must be wet; iteration in cut; consistent cut on processor boundary; adjust cut for 2-D geometries in case STL is not normal; report zero area IBM face 2019-04-05 15:31:52 +01:00
Hrvoje Jasak
39501b9254 Comment 2019-04-05 15:28:41 +01:00
Hrvoje Jasak
f8f6b78897 Added info on volume change in mesh motion 2019-04-03 13:05:34 +01:00
Hrvoje Jasak
49124b24c2 Formatting 2019-04-03 11:05:08 +01:00
Hrvoje Jasak
6071684d0f Merge branch 'nextRelease' of ssh://git.code.sf.net/p/foam-extend/foam-extend-4.0 into nextRelease 2019-03-30 10:44:19 +00:00
Hrvoje Jasak
4d6f8b5bec Better report on volume change 2019-03-29 21:51:08 +00:00
Hrvoje Jasak
686c7a20ed Formatting 2019-03-29 15:08:02 +00:00
Vuko Vukcevic
038f60dc73 Slight update to solutionControl interface
Changed time and under-relaxation consistency members from private to protected
2019-03-28 17:28:08 +01:00
Hrvoje Jasak
eeefdf7552 Comment on IB patch normal 2019-03-28 15:49:47 +00:00
Hrvoje Jasak
63bd3ed52b Bugfix: Use Sf normal rather than n in moving immersed boundary: they are not parallel due to Marooney maneouvre 2019-03-28 15:49:14 +00:00
Hrvoje Jasak
8207c9cd62 Do not write phi in immersedBoundaryFvsPatchField 2019-03-28 15:48:35 +00:00
Hrvoje Jasak
1ce46b1f08 Reset field to zero if size is updated 2019-03-28 15:09:12 +00:00
Hrvoje Jasak
6c2263a2bf Tight tolerances on mesh motion error 2019-03-27 18:12:22 +00:00
Hrvoje Jasak
62228e7189 Reduced immersed boundary cutting tolerances 2019-03-22 13:34:00 +00:00
Hrvoje Jasak
24043c0817 Added virtual functions; removed looks in boundary FV data updates for IB patch 2019-03-22 13:33:07 +00:00
Hrvoje Jasak
60fa49504f Calculate Co number only on large live faces 2019-03-22 13:31:02 +00:00
Hrvoje Jasak
b7dffa272f Added virtual nf function directly from cut patch 2019-03-22 13:30:58 +00:00
Hrvoje Jasak
ec3b5f5574 Robustness: use hinv in fvcReconstruct to deal with cases of zero determinant 2019-03-22 13:26:21 +00:00
Hrvoje Jasak
f75b75df7b Make nf function virtual: better accuract for immersed boundary 2019-03-22 13:25:48 +00:00
Hrvoje Jasak
7ea4631c84 Stability fix: hinv inverse of truly singular tensors 2019-03-22 11:49:53 +00:00
Hrvoje Jasak
7fc1abd4b7 Added wet surface check for dry face 2019-03-15 10:47:56 +00:00
Hrvoje Jasak
85e0d4f65e Improbed Marooney Maneouvre debug message 2019-03-15 10:46:57 +00:00
Hrvoje Jasak
6fe4ba3aa3 Immersed boundary robustness improvements 2019-03-13 12:19:27 +00:00
Hrvoje Jasak
5fce429505 Improved immersed boundary quality check 2019-03-13 12:17:43 +00:00
Vuko Vukcevic
ac71ae4d16 Added a few comments regarding recent bugfixes 2019-03-08 12:51:33 +01:00
Vuko Vukcevic
d1116b86a9 Temporary change in refinement.C regarding edge consistency
Removed FatalError and instead issuing a warning (if debug) for runs with
Parallel Load Balancing. Still need to test thoroughly
2019-02-20 13:54:16 +01:00
Vuko Vukcevic
cea60ab8ab Refactorisation in refinement polyMeshModifier
Moved extendMarkedCellsAcrossFaces and extendMarkedCellsAcrossPoints from
refinement to meshTools.
2019-02-20 12:55:06 +01:00
Vuko Vukcevic
0efa19e651 Wrapped DLB output around if (debug) 2019-02-20 12:06:25 +01:00
Vuko Vukcevic
7f08269ab2 Two bugfixes:
1. polyTopoChanger::changeMesh -> call to polyTopoChanger::update needs to
   happen after polyMesh::updateMesh (more specifically,
   polyBoundaryMesh::updateMesh) in order to correctly build the processor data,
2. refinement::updateMesh -> now that number 1 is fixed, point sync happens in
   updateMesh instead of setRefinement.

These two combined were responsible for hard-to-track errors in AMR + DLB
2019-02-19 22:15:16 +01:00
Vuko Vukcevic
5526c3a048 Updated comment for member function 2019-02-19 21:59:45 +01:00
Vuko Vukcevic
bb23c4851d Bugfix on debug
When issuing a Warning, don't raise FatalError
2019-02-18 13:04:44 +01:00
Vuko Vukcevic
3742439d0f Bugfix in prismatic2DRefinement
Mistakenly used patch.size() instead of patch.start() to fetch the global face
index. This caused points at the boundary to be marked as split points, which is
not allowed. Also corrected a few typos.
2019-02-17 12:01:18 +01:00
Vuko Vukcevic
712807e126 Removed temporary debug stuff from polyhedralRefinement 2019-02-17 10:01:18 +01:00
Vuko Vukcevic
33c4eb5986 Minor formatting and debug output 2019-02-17 10:00:41 +01:00
Vuko Vukcevic
9871df3d78 Added minimum protected level to protectedInitialRefinement 2019-02-17 09:59:35 +01:00
Vuko Vukcevic
46756467b4 Improvement in globalProcFaceIndex
globalProcFaceIndex::globalLabel returns a reference and not a copy
2019-02-17 00:34:17 +01:00
Vuko Vukcevic
028cafdb32 Slight refactorisation in processorMeshesReconstructor::reconstructMesh 2019-02-17 00:32:00 +01:00
Vuko Vukcevic
f1c714eabf Upper-triangular neighbour ordering PLB bugfix
In PLB, the upper-triangular error (for neighbours of a given owner) was
appearing because the faces merged from two processor patches into an internal
face were not ordered correctly. This is now fixed by sorting out these faces
when doing the decomposition.
2019-02-17 00:29:14 +01:00
Danial Khazaei
e8a0078301
[bugfix]: 64-bit label bugfix some how got overwritten by cfMesh update. 2019-02-16 02:21:29 +03:30
Danial Khazaei
7fee1a978c
[cxx-syntax]: consistent usage of nullptr. 2019-02-16 00:22:28 +03:30
Danial Khazaei
c429f3b275
[bugfix]: recover velocity field in a more general way.
avoiding compilation failure in e.g. waves2Foam
2019-02-15 23:19:15 +03:30
Danial Khazaei
be47d0ece1
[format]: make forward declaration style consistent. 2019-02-15 23:12:44 +03:30
Danial Khazaei
0642eb7c4a
[bugfix]: friend operators need forward declaration to avoid gcc warning.
Without forward declaration, gcc warns that the operator has not been declared
within foam but only as a friend.
2019-02-15 22:30:51 +03:30
Hrvoje Jasak
f1545bac95 Cleanup 2019-02-14 18:08:48 +00:00