Bug in CMakeLists.txt #37

Closed

Gregor Weiss wants to merge 0 commits from cmake/bug-fix into main

Gregor Weiss commented

2024-07-01 15:21:06 +00:00

Collaborator

Currently, cmake throws

CMake Error at CMakeLists.txt:134 (if):
  if given arguments:

    "Release" "STREQUAL" "Release" "OR"

  Unknown arguments specified

from here

if("${CMAKE_BUILD_TYPE}" STREQUAL "Release" OR ${OMP})

Fix on would be

if("${CMAKE_BUILD_TYPE}" STREQUAL "Release" OR "${OMP}")

Currently, cmake throws ``` CMake Error at CMakeLists.txt:134 (if): if given arguments: "Release" "STREQUAL" "Release" "OR" Unknown arguments specified ``` from here https://code.hlrs.de/TOPIO/BigWhoop/src/commit/41ec39574f0f3bad53e645b863ec09390da6698d/CMakeLists.txt#L134 Fix on would be ``` if("${CMAKE_BUILD_TYPE}" STREQUAL "Release" OR "${OMP}") ```

Patrick Vogler was assigned by Gregor Weiss

2024-07-01 15:21:06 +00:00

Patrick Vogler commented

2024-07-01 17:17:05 +00:00

Owner

The bug only shows up when not using the makefile wrapper. Seems like a sensible addition, however, the commit appears to not be signed. Could you recommit with a proper signature so I can merge the pull request?

Gregor Weiss force-pushed cmake/bug-fix from 08747698c7 to 1cebbd2d2c

2024-07-01 18:34:17 +00:00

Compare