TOPIO/BigWhoop
TOPIO/BigWhoop
4
1
Fork 0
Code Issues 28 Pull requests Projects 6 Releases Packages Wiki Activity

suggestion with hardcoded header file list #27

Closed
Gregor Weiss wants to merge 0 commits from fix-public-header-creation into main
pull from: fix-public-header-creation
merge into: TOPIO:main
Conversation 1 Commits - Files changed -
Gregor Weiss commented 2024-04-12 10:40:39 +00:00
Collaborator
Copy link

appends possibly missing header files
assumes that missing header files need no dedicated position in the list

Issue #19

appends possibly missing header files assumes that missing header files need no dedicated position in the list Issue #19
Gregor Weiss added 1 commit 2024-04-12 10:40:40 +00:00 
append possibly missing header files
assumes that missing header files need no dedicated position in list
Gregor Weiss added this to the Interfaces project 2024-04-12 10:41:54 +00:00
Gregor Weiss self-assigned this 2024-04-12 10:42:02 +00:00
Patrick Vogler was assigned by Gregor Weiss 2024-04-12 10:42:13 +00:00
Gregor Weiss requested review from Patrick Vogler 2024-04-12 11:15:58 +00:00
Patrick Vogler was unassigned by Gregor Weiss 2024-04-12 11:17:13 +00:00
Patrick Vogler requested changes 2024-04-12 11:52:15 +00:00
Dismissed
Patrick Vogler left a comment
Owner
Copy link

Any header file that has not been hardcoded into the public_header.py script will only be appended in the bwc.h file. This will not work if the definitions in the hardcoded files are dependent upon appended header information. We should print a warning during compile time if new header files are present so a developer is aware that he can hardcode his new header file into the script.

Any header file that has not been hardcoded into the public_header.py script will only be appended in the bwc.h file. This will not work if the definitions in the hardcoded files are dependent upon appended header information. We should print a warning during compile time if new header files are present so a developer is aware that he can hardcode his new header file into the script.
Gregor Weiss force-pushed fix-public-header-creation from f12bd49892 to f66091747a 2024-04-15 12:00:02 +00:00 Compare
Gregor Weiss commented 2024-04-15 12:03:01 +00:00
Author
Collaborator
Copy link

After introducing a solution with an exclude_files list I also opted for renaming header_files to include_files.

After introducing a solution with an `exclude_files` list I also opted for renaming `header_files` to `include_files`.
Gregor Weiss requested review from Patrick Vogler 2024-04-15 12:03:33 +00:00
Patrick Vogler approved these changes 2024-04-15 13:16:30 +00:00
Dismissed
Patrick Vogler approved these changes 2024-04-15 13:17:36 +00:00
Dismissed
Patrick Vogler changed title from WIP: suggestion with hardcoded header file list to suggestion with hardcoded header file list 2024-04-15 13:19:25 +00:00
Patrick Vogler changed title from suggestion with hardcoded header file list to WIP: suggestion with hardcoded header file list 2024-04-15 13:35:43 +00:00
Patrick Vogler requested changes 2024-04-15 13:43:01 +00:00
Patrick Vogler left a comment
Owner
Copy link

The iteration over include_files for the derrived_types results in the inclusion of the bitstream stuct in the public header. Only definitions with the prefix 'bwc_' should be pulled into the public header. This is possible due to a print flag not being reset after iterating over a viable struct. The kernels that search for public definitions should be rechecked to make sure that only the intendet definitions are included. Everything else looks good.

The iteration over include_files for the derrived_types results in the inclusion of the bitstream stuct in the public header. Only definitions with the prefix 'bwc_' should be pulled into the public header. This is possible due to a print flag not being reset after iterating over a viable struct. The kernels that search for public definitions should be rechecked to make sure that only the intendet definitions are included. Everything else looks good.
Gregor Weiss added 1 commit 2024-04-15 14:09:29 +00:00
Patrick Vogler changed title from WIP: suggestion with hardcoded header file list to suggestion with hardcoded header file list 2024-04-15 14:45:35 +00:00
Patrick Vogler closed this pull request 2024-04-15 14:49:46 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Patrick Vogler
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Interfaces
Assignees
Clear assignees
No assignees
Gregor Weiss
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TOPIO/BigWhoop#27
No description provided.
Delete branch "fix-public-header-creation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?