spack

History

Peter Scheibel f2ddffb840 bugfix: web.push_to_url should not format the local path that is passed to it (#13408 ) `fd58c98` formats the `Stage`'s `archive_path` in `Stage.archive` (as part of `web.push_to_url`). This is not needed and if the formatted differs from the original path (for example if the archive file name contains a URL query suffix), then the copy fails. This removes the formatting that occurs in `web.push_to_url`. We should figure out a way to handle bad cases like this and to have nicer filenames for downloaded files. One option that would work in this particular case would be to also pass `-J` / `--remote-header-name` to `curl`. We'll need to do follow-up work to determine if we can use `-J` everywhere. See also: https://github.com/spack/spack/pull/11117#discussion_r338301058	2019-10-23 16:50:51 -07:00
..
spack	bugfix: web.push_to_url should not format the local path that is passed to it (#13408 )	2019-10-23 16:50:51 -07:00

Peter Scheibel f2ddffb840 bugfix: web.push_to_url should not format the local path that is passed to it (#13408 )

fd58c98 formats the `Stage`'s `archive_path` in `Stage.archive` (as part of `web.push_to_url`). This is not needed and if the formatted differs from the original path (for example if the archive file name contains a URL query suffix), then the copy fails.

This removes the formatting that occurs in `web.push_to_url`.

We should figure out a way to handle bad cases like this *and* to have nicer filenames for downloaded files.  One option that would work in this particular case would be to also pass `-J` / `--remote-header-name` to `curl`.  We'll need to do follow-up work to determine if we can use `-J` everywhere.

See also: https://github.com/spack/spack/pull/11117#discussion_r338301058

2019-10-23 16:50:51 -07:00

spack bugfix: web.push_to_url should not format the local path that is passed to it (#13408 ) 2019-10-23 16:50:51 -07:00