spack/lib/spack
Geoffrey M Oxberry 56fd9bc7b6 AutotoolsPackage: remove redundant libtoolize call
This commit removes redundant calls to `libtoolize` and `aclocal`.

Some configurations, such as a Spack user using macOS with a
Homebrew-installed `libtool` added to their `packages.yaml`, have
`autoreconf` and GNU libtoolize installed as `glibtoolize`, but not
`libtoolize`. While Spack installations of `libtool` built from source
would install `glibtoolize` and symlink `libtoolize` to `glibtoolize`,
an external installation of GNU libtoolize as `glibtoolize` will not
have such a symlink, and thus the call `m.libtoolize()` will throw an
error because `libtoolize` does not exist at the path referenced by
`m.libtoolize()` (i.e.,
`self.spec['libtool'].prefix.bin.join('libtoolize')).

However, on these same systems, `autoreconf` runs correctly, and calls
`glibtoolize` instead of `libtoolize`, when appropriate. Thus,
removing the call to `libtoolize` should resolve the error mentioned
above.

The redundant call to `aclocal` is also removed in this commit because
the maintainers of GNU Automake state that "`aclocal` is expected to
disappear" and suggest that downstream users never call `aclocal`
directly -- rather, they suggest calling `autoreconf` instead.
2019-08-27 18:03:56 -07:00
..
docs RPackage docs: use cloud.r-project.org (#12471) 2019-08-25 12:34:58 -05:00
env Add implicit rpaths to compiler detection (#7153) 2019-08-24 06:21:45 -07:00
external copyright: update license headers for 2013-2019 copyright. 2019-01-01 00:44:28 -08:00
llnl permissions: fix file permissions on intermediate install directories (#12399) 2019-08-20 23:08:02 -07:00
spack AutotoolsPackage: remove redundant libtoolize call 2019-08-27 18:03:56 -07:00