857749a9ba
I lost my mind a bit after getting the completion stuff working and decided to get Mypy working for spack as well. This adds a `.mypy.ini` that checks all of the spack and llnl modules, though not yet packages, and fixes all of the identified missing types and type issues for the spack library. In addition to these changes, this includes: * rename `spack flake8` to `spack style` Aliases flake8 to style, and just runs flake8 as before, but with a warning. The style command runs both `flake8` and `mypy`, in sequence. Added --no-<tool> options to turn off one or the other, they are on by default. Fixed two issues caught by the tools. * stub typing module for python2.x We don't support typing in Spack for python 2.x. To allow 2.x to support `import typing` and `from typing import ...` without a try/except dance to support old versions, this adds a stub module *just* for python 2.x. Doing it this way means we can only reliably use all type hints in python3.7+, and mypi.ini has been updated to reflect that. * add non-default black check to spack style This is a first step to requiring black. It doesn't enforce it by default, but it will check it if requested. Currently enforcing the line length of 79 since that's what flake8 requires, but it's a bit odd for a black formatted project to be quite that narrow. All settings are in the style command since spack has no pyproject.toml and I don't want to add one until more discussion happens. Also re-format `style.py` since it no longer passed the black style check with the new length. * use style check in github action Update the style and docs action to use `spack style`, adding in mypy and black to the action even if it isn't running black right now.
73 lines
1.9 KiB
INI
73 lines
1.9 KiB
INI
# -*- conf -*-
|
|
# flake8 settings for Spack core files.
|
|
#
|
|
# These exceptions are for Spack core files. We're slightly more lenient
|
|
# with packages. See .flake8_packages for that.
|
|
#
|
|
# E1: Indentation
|
|
# - E129: visually indented line with same indent as next logical line
|
|
#
|
|
# E2: Whitespace
|
|
# - E221: multiple spaces before operator
|
|
# - E241: multiple spaces after ','
|
|
# - E272: multiple spaces before keyword
|
|
#
|
|
# E7: Statement
|
|
# - E731: do not assign a lambda expression, use a def
|
|
#
|
|
# W5: Line break warning
|
|
# - W503: line break before binary operator
|
|
# - W504: line break after binary operator
|
|
#
|
|
# These are required to get the package.py files to test clean:
|
|
# - F999: syntax error in doctest
|
|
#
|
|
# N8: PEP8-naming
|
|
# - N801: class names should use CapWords convention
|
|
# - N813: camelcase imported as lowercase
|
|
# - N814: camelcase imported as constant
|
|
#
|
|
# F4: pyflakes import checks, these are now checked by mypy more precisely
|
|
# - F403: from module import *
|
|
# - F405: undefined name or from *
|
|
#
|
|
# Black ignores, these are incompatible with black style and do not follow PEP-8
|
|
# - E203: white space around slice operators can be required, ignore : warn
|
|
# - W503: see above, already ignored for line-breaks
|
|
#
|
|
[flake8]
|
|
ignore = E129,E221,E241,E272,E731,W503,W504,F999,N801,N813,N814,F403,F405
|
|
max-line-length = 88
|
|
|
|
# F4: Import
|
|
# - F405: `name` may be undefined, or undefined from star imports: `module`
|
|
#
|
|
# F8: Name
|
|
# - F821: undefined name `name`
|
|
#
|
|
per-file-ignores =
|
|
var/spack/repos/*/package.py:F405,F821
|
|
|
|
# exclude things we usually do not want linting for.
|
|
# These still get linted when passed explicitly, as when spack flake8 passes
|
|
# them on the command line.
|
|
exclude =
|
|
.git
|
|
etc/
|
|
opt/
|
|
share/
|
|
var/spack/cache/
|
|
var/spack/gpg*/
|
|
var/spack/junit-report/
|
|
var/spack/mock-configs/
|
|
lib/spack/external
|
|
__pycache__
|
|
var
|
|
|
|
format = spack
|
|
|
|
[flake8:local-plugins]
|
|
report =
|
|
spack = flake8_formatter:SpackFormatter
|
|
paths =
|
|
./share/spack/qa/
|