69f7a8f4d1
This patchset refactors our GitHub actions into a single top-level ci workflow that invokes a series of reusable actions. The main goal of this is to be able to easily control which tests run and in what order based on the success or failure of top-level prechecks. Our previous workflows ran in three sets: * nix tests: style and verification first, then linux and macos tests if successful * windows tests: style and verification first, then linux and macos tests if successful * bootstrap tests As a result, the bootstrap tests ran even if the style failed, and style and verification had to run on two different platforms despite running identical checks. I'm relatively sure that's because of the limitation on dependencies between steps in the jobs. Reusable workflows allow us to run the style, verification and now audit checks once, then depending on the results, and the files changed, run the appropriate nix, windows and bootstrap tests. While it saves only a few minutes by itself, this makes it easier to refactor checks to subset tests without having to replicate tests or other workflow components in the future. Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
93 lines
3.5 KiB
YAML
93 lines
3.5 KiB
YAML
name: ci
|
|
|
|
on:
|
|
push:
|
|
branches:
|
|
- develop
|
|
- releases/**
|
|
pull_request:
|
|
branches:
|
|
- develop
|
|
- releases/**
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_number }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
prechecks:
|
|
needs: [ changes ]
|
|
uses: ./.github/workflows/valid-style.yml
|
|
with:
|
|
with_coverage: ${{ needs.changes.outputs.with_coverage }}
|
|
# Check which files have been updated by the PR
|
|
changes:
|
|
runs-on: ubuntu-latest
|
|
# Set job outputs to values from filter step
|
|
outputs:
|
|
bootstrap: ${{ steps.filter.outputs.bootstrap }}
|
|
core: ${{ steps.filter.outputs.core }}
|
|
packages: ${{ steps.filter.outputs.packages }}
|
|
with_coverage: ${{ steps.coverage.outputs.with_coverage }}
|
|
steps:
|
|
- uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # @v2
|
|
if: ${{ github.event_name == 'push' }}
|
|
with:
|
|
fetch-depth: 0
|
|
# For pull requests it's not necessary to checkout the code
|
|
- uses: dorny/paths-filter@b2feaf19c27470162a626bd6fa8438ae5b263721
|
|
id: filter
|
|
with:
|
|
# See https://github.com/dorny/paths-filter/issues/56 for the syntax used below
|
|
# Don't run if we only modified packages in the
|
|
# built-in repository or documentation
|
|
filters: |
|
|
bootstrap:
|
|
- '!var/spack/repos/builtin/**'
|
|
- 'var/spack/repos/builtin/packages/clingo-bootstrap/**'
|
|
- 'var/spack/repos/builtin/packages/clingo/**'
|
|
- 'var/spack/repos/builtin/packages/python/**'
|
|
- 'var/spack/repos/builtin/packages/re2c/**'
|
|
- '!lib/spack/docs/**'
|
|
- 'lib/spack/**'
|
|
- 'share/spack/**'
|
|
- '.github/workflows/bootstrap.yml'
|
|
core:
|
|
- './!(var/**)/**'
|
|
packages:
|
|
- 'var/**'
|
|
# Some links for easier reference:
|
|
#
|
|
# "github" context: https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#github-context
|
|
# job outputs: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idoutputs
|
|
# setting environment variables from earlier steps: https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-environment-variable
|
|
#
|
|
- id: coverage
|
|
# Run the subsequent jobs with coverage if core has been modified,
|
|
# regardless of whether this is a pull request or a push to a branch
|
|
run: |
|
|
echo Core changes: ${{ steps.filter.outputs.core }}
|
|
echo Event name: ${{ github.event_name }}
|
|
if [ "${{ steps.filter.outputs.core }}" == "true" ]
|
|
then
|
|
echo "::set-output name=with_coverage::true"
|
|
else
|
|
echo "::set-output name=with_coverage::false"
|
|
fi
|
|
bootstrap:
|
|
if: ${{ github.repository == 'spack/spack' && needs.changes.outputs.bootstrap == 'true' }}
|
|
needs: [ prechecks, changes ]
|
|
uses: ./.github/workflows/bootstrap.yml
|
|
unit-tests:
|
|
if: ${{ github.repository == 'spack/spack' }}
|
|
needs: [ prechecks, changes ]
|
|
uses: ./.github/workflows/unit_tests.yaml
|
|
with:
|
|
core: ${{ needs.changes.outputs.core }}
|
|
packages: ${{ needs.changes.outputs.packages }}
|
|
with_coverage: ${{ needs.changes.outputs.with_coverage }}
|
|
windows:
|
|
if: ${{ github.repository == 'spack/spack' }}
|
|
needs: [ prechecks ]
|
|
uses: ./.github/workflows/windows_python.yml
|
|
|