39b9f214a8
* Perform external spec detection with multiple workers The logic to perform external spec detection has been refactored into classes. These classes use the GoF "template" pattern to account for the small differences between searching for "executables" and for "libraries", while unifying the larger part of the algorithm. A ProcessPoolExecutor is used to parallelize the work. * Speed-up external find by tagging detectable packages automatically Querying packages by tag is much faster than inspecting the repository, since tags are cached. This commit adds a "detectable" tag to every package that implements the detection protocol, and external detection uses it to search for packages. * Pass package names instead of package classes to workers The slowest part of the search is importing the Python modules associated with candidate packages. The import is done serially before we distribute the work to the pool of executors. This commit pushes the import of the Python module to the job performed by the workers, and passes just the name of the packages to the executors. In this way imports can be done in parallel. * Rework unit-tests for Windows Some unit tests were doing a full e2e run of a command just to check a input handling. Make the test more focused by just stressing a specific function. Mark as xfailed 2 tests on Windows, that will be fixed by a PR in the queue. The tests are failing because we monkeypatch internals in the parent process, but the monkeypatching is not done in the "spawned" child process.
79 lines
2.5 KiB
YAML
79 lines
2.5 KiB
YAML
name: windows
|
|
|
|
on:
|
|
workflow_call:
|
|
|
|
concurrency:
|
|
group: windows-${{github.ref}}-${{github.event.pull_request.number || github.run_number}}
|
|
cancel-in-progress: true
|
|
|
|
defaults:
|
|
run:
|
|
shell:
|
|
powershell Invoke-Expression -Command "./share/spack/qa/windows_test_setup.ps1"; {0}
|
|
jobs:
|
|
unit-tests:
|
|
runs-on: windows-latest
|
|
steps:
|
|
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac
|
|
with:
|
|
fetch-depth: 0
|
|
- uses: actions/setup-python@61a6322f88396a6271a6ee3565807d608ecaddd1
|
|
with:
|
|
python-version: 3.9
|
|
- name: Install Python packages
|
|
run: |
|
|
python -m pip install --upgrade pip pywin32 setuptools pytest-cov clingo
|
|
- name: Create local develop
|
|
run: |
|
|
./.github/workflows/setup_git.ps1
|
|
- name: Unit Test
|
|
run: |
|
|
spack unit-test -x --verbose --cov --cov-config=pyproject.toml --ignore=lib/spack/spack/test/cmd
|
|
./share/spack/qa/validate_last_exit.ps1
|
|
coverage combine -a
|
|
coverage xml
|
|
- uses: codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d
|
|
with:
|
|
flags: unittests,windows
|
|
unit-tests-cmd:
|
|
runs-on: windows-latest
|
|
steps:
|
|
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac
|
|
with:
|
|
fetch-depth: 0
|
|
- uses: actions/setup-python@61a6322f88396a6271a6ee3565807d608ecaddd1
|
|
with:
|
|
python-version: 3.9
|
|
- name: Install Python packages
|
|
run: |
|
|
python -m pip install --upgrade pip pywin32 setuptools coverage pytest-cov clingo
|
|
- name: Create local develop
|
|
run: |
|
|
./.github/workflows/setup_git.ps1
|
|
- name: Command Unit Test
|
|
run: |
|
|
spack unit-test -x --verbose --cov --cov-config=pyproject.toml lib/spack/spack/test/cmd
|
|
./share/spack/qa/validate_last_exit.ps1
|
|
coverage combine -a
|
|
coverage xml
|
|
- uses: codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d
|
|
with:
|
|
flags: unittests,windows
|
|
build-abseil:
|
|
runs-on: windows-latest
|
|
steps:
|
|
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac
|
|
with:
|
|
fetch-depth: 0
|
|
- uses: actions/setup-python@61a6322f88396a6271a6ee3565807d608ecaddd1
|
|
with:
|
|
python-version: 3.9
|
|
- name: Install Python packages
|
|
run: |
|
|
python -m pip install --upgrade pip pywin32 setuptools coverage
|
|
- name: Build Test
|
|
run: |
|
|
spack compiler find
|
|
spack -d external find cmake ninja
|
|
spack -d install abseil-cpp
|