Todd Gamblin
67d27841ae
black: configuration
...
This adds necessary configuration for flake8 and black to work together.
This also sets the line length to 99, per the data here:
* https://github.com/spack/spack/pull/24718#issuecomment-876933636
Given the data and the spirit of black's 88-character limit, we set the limit to 99
characters for all of Spack, because:
* 99 is one less than 100, a nice round number, and all lines will fit in a
100-character wide terminal (even when the text editor puts a \ at EOL).
* 99 is just past the knee the file size curve for packages, and it means that packages
remain readable and not significantly longer than they are now.
* It doesn't seem to hurt core -- files in core might change length by a few percent but
seem like they'll be mostly the same as before -- just a bit more roomy.
- [x] set line length to 99
- [x] remove most exceptions from `.flake8` and add the ones black cares about
- [x] add `[tool.black]` to `pyproject.toml`
- [x] make `black` run if available in `spack style --fix`
Co-Authored-By: Tom Scogland <tscogland@llnl.gov>
2022-07-31 13:29:20 -07:00
dependabot[bot]
e33a57ab65
build(deps): bump actions/setup-python from 4.0.0 to 4.1.0 ( #31526 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 4.0.0 to 4.1.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](d09bd5e600...c4e89fac7e
2022-07-12 13:50:30 +02:00
Massimiliano Culpo
667c39987c
py-setuptools: install setuptools from wheels directly ( #31131 )
...
When installing setuptools from sources in Spack, we might
get into weird failures due to the way we use pip.
In particular, for Spack it's necessary to install in a
non-isolated pip environment to allow using PYTHONPATH as a
selection method for all the build requirements of a
Python package.
This can fail when installing setuptools since there might
be a setuptools version already installed for the Python
interpreter being used, with different entry points than
the one we want to install.
Installing from wheels both pip and setuptools should
harden our installation procedure in the context of:
- Bootstrapping Python dependencies of Spack
- Using external Python packages
2022-06-17 10:42:28 +02:00
Massimiliano Culpo
4fd5ee1d9d
CI: test binary bootstrapping of clingo on all macOS versions ( #31160 )
2022-06-16 07:26:20 -04:00
Massimiliano Culpo
7d96a0aa5a
Pin setuptools version in Github Action Workflows ( #31118 )
...
fixes #31109
2022-06-13 21:09:16 +02:00
dependabot[bot]
163251aa65
build(deps): bump actions/setup-python from 3.1.2 to 4 ( #31059 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 3.1.2 to 4.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](98f2ad02fd...d09bd5e600
2022-06-10 11:03:36 +02:00
Adam J. Stewart
57822d3014
clingo: fix ~python build ( #30824 )
2022-06-09 07:33:56 +02:00
Massimiliano Culpo
3fdb3f832a
Cancel running workflows automatically on PR update ( #31044 )
...
* Cancel running workflows automatically on PR update
* Add the last update later to check cancellation is working
* Use github.run_number instead of github.sha
2022-06-08 15:46:46 -07:00
Adam J. Stewart
2bda10edb5
Fix typo in GitHub Actions step name ( #30924 )
2022-06-02 16:33:39 +00:00
Scott Wittenburg
70824e4a5e
buildcache: Update layout and signing ( #30750 )
...
This PR introduces a new build cache layout and package format, with improvements for
both efficiency and security.
## Old Format
Currently a binary package consists of a `spec.json` file at the root and a `.spack` file,
which is a `tar` archive containing a copy of the `spec.json` format, possibly a detached
signature (`.asc`) file, and a tar-gzip compressed archive containing the install tree.
```
build_cache/
# metadata (for indexing)
<arch>-<compiler>-<name>-<ver>-24zvipcqgg2wyjpvdq2ajy5jnm564hen.spec.json
<arch>/
<compiler>/
<name>-<ver>/
# tar archive
<arch>-<compiler>-<name>-<ver>-24zvipcqgg2wyjpvdq2ajy5jnm564hen.spack
# tar archive contents:
# metadata (contains sha256 of internal .tar.gz)
<arch>-<compiler>-<name>-<ver>-24zvipcqgg2wyjpvdq2ajy5jnm564hen.spec.json
# signature
<arch>-<compiler>-<name>-<ver>-24zvipcqgg2wyjpvdq2ajy5jnm564hen.spec.json.asc
# tar.gz-compressed prefix
<arch>-<compiler>-<name>-<ver>-24zvipcqgg2wyjpvdq2ajy5jnm564hen.tar.gz
```
After this change, the nesting has been removed so that the `.spack` file is the
compressed archive of the install tree. Now signed binary packages, will take the
form of a clearsigned `spec.json` file (a `spec.json.sig`) at the root, while unsigned
binary packages will contain a `spec.json` at the root.
## New Format
```
build_cache/
# metadata (for indexing, contains sha256 of .spack file)
<arch>-<compiler>-<name>-<ver>-24zvipcqgg2wyjpvdq2ajy5jnm564hen.spec.json
# clearsigned spec.json metadata
<arch>-<compiler>-<name>-<ver>-24zvipcqgg2wyjpvdq2ajy5jnm564hen.spec.json.sig
<arch>/
<compiler>/
<name>-<ver>/
# tar.gz-compressed prefix (may support more compression formats later)
<arch>-<compiler>-<name>-<ver>-24zvipcqgg2wyjpvdq2ajy5jnm564hen.spack
```
## Benefits
The major benefit of this change is that the signatures on binary packages can be
verified without:
1. Having to download the tarball, or
2. having to extract an unknown tarball.
(1) is an improvement in efficiency; (2) is a security fix: we now ensure that we trust the
binary before we try to run it through `tar`, which avoids potential attacks.
## Backward compatibility
Also after this change, spack should still be able to handle the previous buildcache
structure and binary mirrors with mixed layouts.
2022-05-24 17:39:20 -04:00
dependabot[bot]
24f370491e
build(deps): bump actions/upload-artifact from 3 to 3.1.0 ( #30778 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 3 to 3.1.0.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](https://github.com/actions/upload-artifact/compare/v3...3cea5372237819ed00197afe530f5a7ea3e805c8 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-21 08:57:19 +02:00
Wileam Y. Phan
30f2394782
Run scheduled CI workflows only in the main repo ( #30729 )
...
Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
2022-05-19 21:35:52 +02:00
Todd Gamblin
555202833f
bootstrap: clean up CI workflows a bit ( #30574 )
...
- [x] Add `mkdir -p` and `chmod` to ensure `/home/spack-test` exists and
has correct permissions.
- [x] Remove version comments from dependabot-managed action commits
- [x] Don't duplicate comment describing required fixes for distros with
patched git
2022-05-10 16:27:37 +02:00
Massimiliano Culpo
104d60887f
CI: fix bootstrapping on Fedora ( #30559 )
...
Fedora updated git, so we need to apply, again, the
workaround for CVE-2022-24765
2022-05-09 09:11:03 +00:00
dependabot[bot]
999eee64b8
build(deps): bump docker/build-push-action from 2.10.0 to 3 ( #30515 )
...
Bumps [docker/build-push-action](https://github.com/docker/build-push-action ) from 2.10.0 to 3.
- [Release notes](https://github.com/docker/build-push-action/releases )
- [Commits](ac9327eae2...e551b19e49
2022-05-06 08:38:07 +02:00
dependabot[bot]
5d0f2bb461
build(deps): bump docker/setup-qemu-action from 1.2.0 to 2 ( #30518 )
...
Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action ) from 1.2.0 to 2.
- [Release notes](https://github.com/docker/setup-qemu-action/releases )
- [Commits](27d0a4f181...8b122486ce
2022-05-06 08:37:34 +02:00
dependabot[bot]
ec295a13fd
build(deps): bump docker/setup-buildx-action from 1.7.0 to 2 ( #30517 )
...
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action ) from 1.7.0 to 2.
- [Release notes](https://github.com/docker/setup-buildx-action/releases )
- [Commits](f211e3e9de...dc7b9719a9
2022-05-06 08:37:11 +02:00
dependabot[bot]
1b1770ea9e
build(deps): bump docker/login-action from 1.14.1 to 2 ( #30516 )
...
Bumps [docker/login-action](https://github.com/docker/login-action ) from 1.14.1 to 2.
- [Release notes](https://github.com/docker/login-action/releases )
- [Commits](dd4fa0671b...49ed152c8e
2022-05-06 08:36:50 +02:00
dependabot[bot]
3ce8bff22e
build(deps): bump docker/setup-buildx-action from 1.6.0 to 1.7.0 ( #30387 )
...
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action ) from 1.6.0 to 1.7.0.
- [Release notes](https://github.com/docker/setup-buildx-action/releases )
- [Commits](94ab11c41e...f211e3e9de
2022-05-04 06:04:38 +02:00
Massimiliano Culpo
21bf0cf43c
Fix issue in CI with Git 2.35 ( #30436 )
2022-05-02 20:49:53 +00:00
dependabot[bot]
1243717012
build(deps): bump actions/checkout from 2 to 3.0.2 ( #30235 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 2 to 3.0.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v2...2541b1294d2704b0964813337f33b291d3f8596b )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-27 13:47:50 +02:00
dependabot[bot]
3dbbf3a101
build(deps): bump codecov/codecov-action from 3.0.0 to 3.1.0 ( #30234 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 3.0.0 to 3.1.0.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md )
- [Commits](e3c560433a...81cd2dc814
2022-04-27 11:26:19 +02:00
Massimiliano Culpo
f961a11187
Update Dockerfiles and images for Spack v0.18.0 ( #30216 )
...
This PR updates the list of images we build nightly, deprecating
Ubuntu 16.04 and CentOS 8 and adding Ubuntu 20.04, Ubuntu 22.04
and CentOS Stream. It also removes a lot of duplication by generating
the Dockerfiles during the CI workflow and uploading them as artifacts
for later inspection or reuse.
2022-04-22 08:51:26 +02:00
dependabot[bot]
bbb3f724af
build(deps): bump actions/setup-python from 3.1.1 to 3.1.2 ( #30017 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 3.1.1 to 3.1.2.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](21c0493ecf...98f2ad02fd
2022-04-14 10:47:01 +02:00
Massimiliano Culpo
c846b5149d
Add support for Python 3.10 ( #29581 )
...
* Add support for Python 3.10
* Update unit-tests to use 3.10
* Update Getting started section of the docs
* Update bootstrap action
2022-04-13 14:32:23 -07:00
Massimiliano Culpo
0480afe29d
CI: avoid issues with Ubuntu patched git by adding safe.directory ( #30042 )
...
Ubuntu patched git v2.25.1 with a security fix that also
introduced a breaking change, so v2.25.1 behaves like
v2.35.2 with respect to the use cases in CVE-2022-24765
2022-04-13 11:10:00 +00:00
dependabot[bot]
714573cdbc
build(deps): bump actions/setup-python from 3.1.0 to 3.1.1 ( #29956 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](9c644ca2ab...21c0493ecf
2022-04-11 10:50:08 +02:00
dependabot[bot]
7385ea5f01
build(deps): bump actions/upload-artifact from 2 to 3 ( #29981 )
...
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact ) from 2 to 3.
- [Release notes](https://github.com/actions/upload-artifact/releases )
- [Commits](https://github.com/actions/upload-artifact/compare/v2...v3 )
---
updated-dependencies:
- dependency-name: actions/upload-artifact
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-11 09:56:04 +02:00
dependabot[bot]
8e177a45d2
build(deps): bump actions/download-artifact from 2 to 3 ( #29982 )
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 2 to 3.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](https://github.com/actions/download-artifact/compare/v2...v3 )
---
updated-dependencies:
- dependency-name: actions/download-artifact
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-11 09:55:32 +02:00
dependabot[bot]
764a97d428
build(deps): bump codecov/codecov-action from 2.1.0 to 3 ( #29908 )
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 2.1.0 to 3.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md )
- [Commits](f32b3a3741...e3c560433a
2022-04-06 06:08:22 +02:00
dependabot[bot]
105b42c15f
build(deps): bump actions/setup-python from 2 to 3.1.0 ( #29843 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 2 to 3.1.0.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](https://github.com/actions/setup-python/compare/v2...9c644ca2ab8e57ea0a487b5ec2f8290740378bfd )
---
updated-dependencies:
- dependency-name: actions/setup-python
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-04-04 09:55:49 +02:00
dependabot[bot]
b65054881f
build(deps): bump docker/build-push-action from 2.9.0 to 2.10.0 ( #29506 )
...
Bumps [docker/build-push-action](https://github.com/docker/build-push-action ) from 2.9.0 to 2.10.0.
- [Release notes](https://github.com/docker/build-push-action/releases )
- [Commits](7f9d37fa54...ac9327eae2
2022-03-21 16:39:45 +01:00
Harmen Stoppels
282a366fc4
windows ci: make conditional on style tests etc ( #29567 )
2022-03-17 14:20:02 -07:00
Zack Galbreath
5a72204d38
Remove references to features/windows-support branch ( #29565 )
2022-03-17 10:29:29 -07:00
John Parent
4aee27816e
Windows Support: Testing Suite integration
...
Broaden support for execution of the test suite
on Windows.
General bug and review fixups
2022-03-17 09:01:01 -07:00
Betsy McPhail
06aef626cb
Update tests support for Windows
...
Fixup common tests
* Remove requirement for Python 2.6
* Skip new failing test
Windows: Update url util to handle Windows paths (#27959 )
* update url util to handle windows paths
* Update tests to handle fixed url handling
* canonicalize path only when the path type matches the host platform
* Skip some url tests on Windows
Co-authored-by: Omar Padron <omar.padron@kitware.com>
Use threading.TIMEOUT_MAX when available (#24246 )
This value was introduced in Python 3.2. Specifying a timeout greater than
this value will raise an OverflowError.
Co-authored-by: Lou Lawrence <lou.lawrence@kitware.com>
Co-authored-by: John Parent <john.parent@kitware.com>
Co-authored-by: Betsy McPhail <betsy.mcphail@kitware.com>
2022-03-17 09:01:01 -07:00
John Parent
90c773488c
Add Github Actions for Windows ( #24504 )
...
Setup Installer CI (#25184 ), (#25191 )
Co-authored-by: Zack Galbreath <zack.galbreath@kitware.com>
Co-authored-by: lou.lawrence@kitware.com <lou.lawrence@kitware.com>
Co-authored-by: Betsy McPhail <betsy.mcphail@kitware.com>
2022-03-17 09:01:01 -07:00
dependabot[bot]
f6ea56276f
build(deps): bump actions/setup-python from 2.3.1 to 3 ( #29253 )
...
Bumps [actions/setup-python](https://github.com/actions/setup-python ) from 2.3.1 to 3.
- [Release notes](https://github.com/actions/setup-python/releases )
- [Commits](f382193329...0ebf233433
2022-03-03 19:10:47 +01:00
dependabot[bot]
ed6274a0bf
build(deps): bump actions/checkout from 2 to 3 ( #29276 )
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v2...a12a3943b4bdde767164f792f33f40b04645d846 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-03-03 14:43:49 +01:00
dependabot[bot]
450bbdd854
build(deps): bump docker/login-action from 1.13.0 to 1.14.1 ( #29277 )
...
Bumps [docker/login-action](https://github.com/docker/login-action ) from 1.13.0 to 1.14.1.
- [Release notes](https://github.com/docker/login-action/releases )
- [Commits](6af3c118c8...dd4fa0671b
2022-03-03 14:42:28 +01:00
dependabot[bot]
b08ed91309
build(deps): bump docker/login-action from 1.12.0 to 1.13.0 ( #29053 )
...
Bumps [docker/login-action](https://github.com/docker/login-action ) from 1.12.0 to 1.13.0.
- [Release notes](https://github.com/docker/login-action/releases )
- [Commits](42d299face...6af3c118c8
2022-02-22 15:18:38 +01:00
Massimiliano Culpo
ffa58a20c6
CI: pin the version of pathlib to v2.3.6 ( #28832 )
2022-02-08 20:00:20 +00:00
dependabot[bot]
dd7acecf3d
build(deps): bump docker/build-push-action from 2.8.0 to 2.9.0 ( #28719 )
...
Bumps [docker/build-push-action](https://github.com/docker/build-push-action ) from 2.8.0 to 2.9.0.
- [Release notes](https://github.com/docker/build-push-action/releases )
- [Commits](1814d3dfb3...7f9d37fa54
2022-02-02 11:57:31 +01:00
Massimiliano Culpo
7c31d4d279
CI: macOS try to build latest GCC ( #28709 )
2022-02-01 21:29:27 +01:00
Massimiliano Culpo
4bd761d1d5
Update actions/setup-python to latest version ( #28634 )
2022-01-28 14:17:59 +01:00
Massimiliano Culpo
b9b1665cb2
Pin the version of "coverage" in CI to 6.2 ( #28638 )
...
Hotfix for coverage v6.3 blocking our CI workflows
2022-01-27 20:35:05 +01:00
dependabot[bot]
93ebc4f47b
build(deps): bump docker/build-push-action from 2.7.0 to 2.8.0 ( #28495 )
...
Bumps [docker/build-push-action](https://github.com/docker/build-push-action ) from 2.7.0 to 2.8.0.
- [Release notes](https://github.com/docker/build-push-action/releases )
- [Commits](a66e35b9cb...1814d3dfb3
2022-01-19 11:27:59 +01:00
Massimiliano Culpo
82bdda9a89
Reduce the unit tests jobs for the original concretizer
...
Only test Python 2.7, 3.6 and 3.9
2021-12-23 16:45:06 +01:00
dependabot[bot]
43042c14e0
build(deps): bump docker/login-action from 1.10.0 to 1.12.0 ( #28100 )
...
Bumps [docker/login-action](https://github.com/docker/login-action ) from 1.10.0 to 1.12.0.
- [Release notes](https://github.com/docker/login-action/releases )
- [Commits](f054a8b539...42d299face
2021-12-21 11:29:40 +01:00
Massimiliano Culpo
661fd7bb67
Fix building container images ( #28063 )
...
* Fix building container images
Patchelf is bootstrapped from sources, so we cannot
disable that mechanism until a finer selection is
possible in the configuration.
* Build on changes to the Dockerfile
* Don't login to Dockerhub on PRs
2021-12-17 09:19:21 +00:00
