hlrs-software-stack/spack
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

gperftools: add cmake build system (#43506)

Browse source 
the autotools build system does something funky which causes a link line
where gccs default link dirs are explicitly added and end up before the
-L from spack's libunwind, so that ultimately it links against system
libunwind.

the cmake build system does better.
This commit is contained in:
Harmen Stoppels 2024-04-08 10:00:05 +02:00 committed by GitHub
parent 93e6f5fa4e
commit fd68f8916c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 32 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
var/spack/repos/builtin/packages/gperftools/package.py
View file

@ -3,10 +3,11 @@
# #
# SPDX-License-Identifier: (Apache-2.0 OR MIT) # SPDX-License-Identifier: (Apache-2.0 OR MIT)
from spack.build_systems import autotools, cmake
from spack.package import * from spack.package import *
class Gperftools(AutotoolsPackage): class Gperftools(AutotoolsPackage, CMakePackage):
"""Google's fast malloc/free implementation, especially for """Google's fast malloc/free implementation, especially for
multi-threaded applications. Contains tcmalloc, heap-checker, multi-threaded applications. Contains tcmalloc, heap-checker,
heap-profiler, and cpu-profiler. heap-profiler, and cpu-profiler.
@ -19,6 +20,8 @@ class Gperftools(AutotoolsPackage):
license("BSD-3-Clause") license("BSD-3-Clause")
build_system(conditional("cmake", when="@2.8.1:"), "autotools", default="cmake")
version("2.15", sha256="c69fef855628c81ef56f12e3c58f2b7ce1f326c0a1fe783e5cae0b88cbbe9a80") version("2.15", sha256="c69fef855628c81ef56f12e3c58f2b7ce1f326c0a1fe783e5cae0b88cbbe9a80")
version("2.14", sha256="6b561baf304b53d0a25311bd2e29bc993bed76b7c562380949e7cb5e3846b299") version("2.14", sha256="6b561baf304b53d0a25311bd2e29bc993bed76b7c562380949e7cb5e3846b299")
version("2.13", sha256="4882c5ece69f8691e51ffd6486df7d79dbf43b0c909d84d3c0883e30d27323e7") version("2.13", sha256="4882c5ece69f8691e51ffd6486df7d79dbf43b0c909d84d3c0883e30d27323e7")
@ -43,21 +46,38 @@ class Gperftools(AutotoolsPackage):
) )
depends_on("unwind", when="+libunwind") depends_on("unwind", when="+libunwind")
depends_on("cmake@3.12:", type="build", when="build_system=cmake")
# Linker error: src/base/dynamic_annotations.cc:46: undefined reference to # Linker error: src/base/dynamic_annotations.cc:46: undefined reference to
# `TCMallocGetenvSafe' # `TCMallocGetenvSafe'
conflicts("target=ppc64:", when="@2.14") conflicts("target=ppc64:", when="@2.14")
conflicts("target=ppc64le:", when="@2.14") conflicts("target=ppc64le:", when="@2.14")
def configure_args(self): # the autotools build system creates an explicit list of -L <system dir> flags that end up
args = [] # before the -L <spack dir> flags, which causes the system libunwind to be linked instead of
args += self.enable_or_disable("sized-delete", variant="sized_delete") # the spack libunwind. This is a workaround to fix that.
args += self.enable_or_disable( conflicts("+libunwind", when="build_system=autotools")
"dynamic-sized-delete-support", variant="dynamic_sized_delete_support"
)
args += self.enable_or_disable("debugalloc")
args += self.enable_or_disable("libunwind")
if self.spec.satisfies("+libunwind"):
args += ["LDFLAGS=-lunwind"]
return args
class CMakeBuilder(cmake.CMakeBuilder):
def cmake_args(self):
return [
self.define_from_variant("gperftools_sized_delete", "sized_delete"),
self.define_from_variant(
"gperftools_dynamic_sized_delete_support", "dynamic_sized_delete_support"
),
self.define_from_variant("GPERFTOOLS_BUILD_DEBUGALLOC", "debugalloc"),
self.define_from_variant("gperftools_enable_libunwind", "libunwind"),
]
class AutotooolsBuilder(autotools.AutotoolsBuilder):
def configure_args(self):
return [
*self.enable_or_disable("sized-delete", variant="sized_delete"),
*self.enable_or_disable(
"dynamic-sized-delete-support", variant="dynamic_sized_delete_support"
),
*self.enable_or_disable("debugalloc"),
*self.enable_or_disable("libunwind"),
]