hlrs-software-stack/spack
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

llvm: depend on python only when +python (#11348)

Browse source 
Based on the LLVM documentation [1], Python is used to run the automated
test suite. Therefore is it always a dependency for LLVM. However, if
build without Python (~python), we limit it to a build time dependency.

Note that py-lit is not added as a spack dependency even though it is
available as a spack package. This is because it is already included
in llvm and llvm is difficult to configure using an external py-lit
(several CMake variables to set correctly). Additionally, having
py-lit as a spack dependency adds Python as a runtime dependency
for llvm even though it is not required at runtime.

[1] https://llvm.org/docs/GettingStarted.html#requirements
This commit is contained in:
Chuck Atkins 2019-05-02 16:21:06 -04:00 committed by Omar Padron
parent 5b82bf47af
commit f44443ed3a
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
var/spack/repos/builtin/packages/llvm/package.py
View file

@ -71,11 +71,12 @@ class Llvm(CMakePackage):
# Build dependency # Build dependency
depends_on('cmake@3.4.3:', type='build') depends_on('cmake@3.4.3:', type='build')
depends_on('python@2.7:2.8', when='@:4.999 ~python', type='build')
depends_on('python', when='@5: ~python', type='build')
# Universal dependency # Universal dependency
depends_on('python@2.7:2.8', when='@:4.999') depends_on('python@2.7:2.8', when='@:4.999+python')
depends_on('python') depends_on('python', when='@5:+python')
depends_on('py-lit', type=('build', 'run'))
# openmp dependencies # openmp dependencies
depends_on('perl-data-dumper', type=('build')) depends_on('perl-data-dumper', type=('build'))
@ -607,7 +608,6 @@ def setup_environment(self, spack_env, run_env):
def cmake_args(self): def cmake_args(self):
spec = self.spec spec = self.spec
cmake_args = [ cmake_args = [
'-DLLVM_REQUIRES_RTTI:BOOL=ON', '-DLLVM_REQUIRES_RTTI:BOOL=ON',
'-DLLVM_ENABLE_RTTI:BOOL=ON', '-DLLVM_ENABLE_RTTI:BOOL=ON',