Use self.run_tests for make check

var/spack/repos/builtin/packages/cmake/package.py

@@ -118,5 +118,6 @@ def install(self, spec, prefix):
         bootstrap(*options)
 
         make()
-        # make('test')  # some tests fail, takes forever
+        if self.run_tests:
+            make('test')  # some tests fail, takes forever
         make('install')

var/spack/repos/builtin/packages/expat/package.py

@@ -38,5 +38,6 @@ def install(self, spec, prefix):
         configure('--prefix={0}'.format(prefix))
 
         make()
-        make('check')
+        if self.run_tests:
+            make('check')
         make('install')

var/spack/repos/builtin/packages/jsoncpp/package.py

@@ -44,5 +44,6 @@ def install(self, spec, prefix):
             cmake('..', '-DBUILD_SHARED_LIBS=ON', *std_cmake_args)
 
             make()
-            # make('test')  # Python needed to run tests
+            if self.run_tests:
+                make('test')  # Python needed to run tests
             make('install')

var/spack/repos/builtin/packages/libarchive/package.py

@@ -52,5 +52,6 @@ def install(self, spec, prefix):
         configure('--prefix={0}'.format(prefix))
 
         make()
-        # make('check')  # cannot build test suite with Intel compilers
+        if self.run_tests:
+            make('check')  # cannot build test suite with Intel compilers
         make('install')

var/spack/repos/builtin/packages/libxml2/package.py

@@ -55,5 +55,6 @@ def install(self, spec, prefix):
         configure('--prefix={0}'.format(prefix), *python_args)
 
         make()
-        make('check')
+        if self.run_tests:
+            make('check')
         make('install')

var/spack/repos/builtin/packages/lz4/package.py

@@ -40,5 +40,6 @@ class Lz4(Package):
 
     def install(self, spec, prefix):
         make()
-        # make('test')  # requires valgrind to be installed
+        if self.run_tests:
+            make('test')  # requires valgrind to be installed
         make('install', 'PREFIX={0}'.format(prefix))

var/spack/repos/builtin/packages/lzma/package.py

@@ -44,5 +44,6 @@ def install(self, spec, prefix):
         configure('--prefix={0}'.format(prefix))
 
         make()
-        make('check')
+        if self.run_tests:
+            make('check')  # one of the tests fails for me
         make('install')

var/spack/repos/builtin/packages/lzo/package.py

@@ -45,6 +45,7 @@ def install(self, spec, prefix):
         ]
         configure(*configure_args)
         make()
-        make('check')
+        if self.run_tests:
-        make('test')  # more exhaustive test
+            make('check')
+            make('test')  # more exhaustive test
         make('install')

var/spack/repos/builtin/packages/nettle/package.py

@@ -41,5 +41,6 @@ def install(self, spec, prefix):
         configure('--prefix={0}'.format(prefix))
 
         make()
-        make('check')
+        if self.run_tests:
+            make('check')
         make('install')

var/spack/repos/builtin/packages/xz/package.py

@@ -40,5 +40,6 @@ def install(self, spec, prefix):
         configure('--prefix={0}'.format(prefix))
 
         make()
-        make('check')
+        if self.run_tests:
+            make('check')
         make('install')

var/spack/repos/builtin/packages/zlib/package.py

@@ -38,5 +38,6 @@ def install(self, spec, prefix):
         configure('--prefix={0}'.format(prefix))
 
         make()
-        make('test')
+        if self.run_tests:
+            make('test')
         make('install')