hlrs-software-stack/spack
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

unifyfs: support openssl 3 (#39945)

Browse source 
* unifyfs: drop upperbound on deprecated openssl

The package uses deprecated MD5 functions from OpenSSL, which causes
warnings, but (a) Spack by default disables -Werror, and (b) those
functions will continue to exist in OpenSSL 3.

* unifyfs: enable parallel build, only make check sequential

* unifyfs: order class methods by install phases
This commit is contained in:
Harmen Stoppels 2023-09-13 08:59:47 +02:00 committed by GitHub
parent e45fc994aa
commit e8740b40da
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
var/spack/repos/builtin/packages/unifyfs/package.py
View file

@ -73,7 +73,10 @@ class Unifyfs(AutotoolsPackage):
# after v0.13.1.
depends_on("mochi-margo@0.10:", when="@1.1:")
depends_on("mpi")
depends_on("openssl@:1")
# unifyfs@:1.1 uses MD5 functions that are deprecated in OpenSSL 3, and
# likely to be removed in the next major release.
depends_on("openssl@:3")
# Mochi-Margo dependencies
depends_on("mercury@1.0.1+bmi", when="@:0.9.1")
@ -94,9 +97,6 @@ class Unifyfs(AutotoolsPackage):
patch("unifyfs-sysio.c.patch", when="@0.9.1")
patch("include-sys-sysmacros.h.patch", when="@0.9.1:0.9.2")
# Parallel disabled to prevent tests from being run out-of-order when
# installed with the --test={root, all} option.
parallel = False
debug_build = False
build_directory = "spack-build"
@ -124,6 +124,15 @@ def setup_build_environment(self, env):
if self.spec.satisfies("%oneapi"):
env.append_flags("CFLAGS", "-Wno-unused-function")
@when("%cce@11.0.3:")
def patch(self):
filter_file("-Werror", "", "client/src/Makefile.in")
filter_file("-Werror", "", "client/src/Makefile.am")
@when("@develop")
def autoreconf(self, spec, prefix):
Executable("./autogen.sh")()
def configure_args(self):
spec = self.spec
args = ["--with-gotcha=%s" % spec["gotcha"].prefix]
@ -142,12 +151,6 @@ def configure_args(self):
return args
@when("@develop")
def autoreconf(self, spec, prefix):
sh = which("sh")
sh("./autogen.sh")
@when("%cce@11.0.3:")
def patch(self):
filter_file("-Werror", "", "client/src/Makefile.in")
filter_file("-Werror", "", "client/src/Makefile.am")
def check(self):
with working_dir(self.build_directory):
make("check", parallel=False)