From d89b09493c65ea996cda79830bf8439b7cb4db46 Mon Sep 17 00:00:00 2001 From: David Hows Date: Fri, 17 Nov 2017 03:28:40 +1100 Subject: [PATCH] Minor package fixes (#6334) * Add no-implicit-fallthrough to MsgpackC * Add 0.2.1 of Neovim * Lint --- var/spack/repos/builtin/packages/msgpack-c/package.py | 7 +++++++ var/spack/repos/builtin/packages/neovim/package.py | 8 +++++--- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/var/spack/repos/builtin/packages/msgpack-c/package.py b/var/spack/repos/builtin/packages/msgpack-c/package.py index bf78e8d931..8e5ac96718 100644 --- a/var/spack/repos/builtin/packages/msgpack-c/package.py +++ b/var/spack/repos/builtin/packages/msgpack-c/package.py @@ -33,3 +33,10 @@ class MsgpackC(CMakePackage): version('1.4.1', 'e2fd3a7419b9bc49e5017fdbefab87e0') depends_on('cmake@2.8.12:', type='build') + + def cmake_args(self): + args = [ + "-DCMAKE_CXX_FLAGS=-Wno-implicit-fallthrough", + "-DCMAKE_C_FLAGS=-Wno-implicit-fallthrough" + ] + return args diff --git a/var/spack/repos/builtin/packages/neovim/package.py b/var/spack/repos/builtin/packages/neovim/package.py index 0f26daf83f..4e779014dd 100644 --- a/var/spack/repos/builtin/packages/neovim/package.py +++ b/var/spack/repos/builtin/packages/neovim/package.py @@ -32,6 +32,7 @@ class Neovim(CMakePackage): homepage = "http://neovim.io" url = "https://github.com/neovim/neovim/archive/v0.2.0.tar.gz" + version('0.2.1', 'f4271f22d2a46fa18dace42849c56a98') version('0.2.0', '9af7f61f9f0b1a2891147a479d185aa2') depends_on('lua@5.1:5.2') @@ -44,10 +45,11 @@ class Neovim(CMakePackage): depends_on('libvterm') depends_on('unibilium') depends_on('msgpack-c') + depends_on('gperf') def cmake_args(self): - # FIXME: Add arguments other than - # FIXME: CMAKE_INSTALL_PREFIX and CMAKE_BUILD_TYPE - # FIXME: If not needed delete this function args = [] + if version >= Version('0.2.1'): + args = ['-DPREFER_LUA=ON'] + return args