hlrs-software-stack/spack
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

installation: skip repository metadata for externals (#16954)

Browse source 
When Spack installs a package, it stores repository package.py files
for it and all of its dependencies - any package with a Spack metadata
directory in its installation prefix.

It turns out this was too broad: this ends up including external
packages installed by Spack (e.g. installed by another Spack instance).
Currently Spack doesn't store the namespace properly for such packages,
so even though the package file could be fetched from the external,
Spack is unable to locate it.

This commit avoids the issue by skipping any attempt to locate and copy
from the package repository of externals, regardless of whether they
have a Spack repo directory.
This commit is contained in:
Greg Becker 2020-07-09 13:08:51 -05:00 committed by GitHub
parent ce9d30f80f
commit d0f5b69a19
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
lib/spack/spack/installer.py
View file

@ -405,9 +405,14 @@ def dump_packages(spec, path):
source = spack.store.layout.build_packages_path(node) source = spack.store.layout.build_packages_path(node)
source_repo_root = os.path.join(source, node.namespace) source_repo_root = os.path.join(source, node.namespace)
# There's no provenance installed for the source package. Skip it. # If there's no provenance installed for the package, skip it.
# User can always get something current from the builtin repo. # If it's external, skip it because it either:
if not os.path.isdir(source_repo_root): # 1) it wasn't built with Spack, so it has no Spack metadata
# 2) it was built by another Spack instance, and we do not
# (currently) use Spack metadata to associate repos with externals
# built by other Spack instances.
# Spack can always get something current from the builtin repo.
if node.external or not os.path.isdir(source_repo_root):
continue continue
# Create a source repo and get the pkg directory out of it. # Create a source repo and get the pkg directory out of it.