hlrs-software-stack/spack
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

concretization: improve performance by avoiding database locks

Browse source 
Checks for deprecated specs were repeatedly taking out read locks on the
database, which can be very slow.

- [x] put a read transaction around the deprecation check
This commit is contained in:
Todd Gamblin 2019-12-16 17:37:47 -08:00
parent 48befd67b5
commit cbf8553406
No known key found for this signature in database
GPG key ID: 66B24B9050FDD0B8
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/spack/spack/spec.py
View file

@ -2243,10 +2243,12 @@ def concretize(self, tests=False):
# If any spec in the DAG is deprecated, throw an error # If any spec in the DAG is deprecated, throw an error
deprecated = [] deprecated = []
with spack.store.db.read_transaction():
for x in self.traverse(): for x in self.traverse():
_, rec = spack.store.db.query_by_spec_hash(x.dag_hash()) _, rec = spack.store.db.query_by_spec_hash(x.dag_hash())
if rec and rec.deprecated_for: if rec and rec.deprecated_for:
deprecated.append(rec) deprecated.append(rec)
if deprecated: if deprecated:
msg = "\n The following specs have been deprecated" msg = "\n The following specs have been deprecated"
msg += " in favor of specs with the hashes shown:\n" msg += " in favor of specs with the hashes shown:\n"