hlrs-software-stack/spack
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

gdbm: fix lmod global name 'spack_cc' undefined (#7225)

Browse source 
Prior to this commit, running `spack module refresh` with `gdbm`
installed throws the warning:

```console
==> Warning: Could not write module file [/Users/oxberry1/spack/share/spack/lmod/darwin-sierra-x86_64/Core/gdbm/1.14.1.lua]
==> Warning:    --> global name 'spack_cc' is not defined <--
```

This warning is repeated for every `gdbm` installation in Spack.

The cause of the issue seems to be the same as in spack/spack (#6089):
using `spack_cc`, `spack_cxx`, or similar inside `configure_args`
causes the warnings to throw when module files are generated.

Moving the use of `spack_cc` into `setup_environment` seems to fix the
problem, even though it's a bit of a kludge.
This commit is contained in:
Geoffrey Oxberry 2018-02-13 23:41:50 -08:00 committed by Massimiliano Culpo
parent 8766daf9de
commit c7274eb1f5
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
var/spack/repos/builtin/packages/gdbm/package.py
View file

@ -45,10 +45,12 @@ class Gdbm(AutotoolsPackage):
depends_on("readline") depends_on("readline")
def setup_environment(self, spack_env, run_env):
spack_env.set('CC', spack_cc)
def configure_args(self): def configure_args(self):
config_args = [ config_args = [
'--enable-libgdbm-compat', '--enable-libgdbm-compat',
'CC=%s' % spack_cc
] ]
return config_args return config_args