From b5a9f8ead14a18c3be24fce97cb2277e1a5baad1 Mon Sep 17 00:00:00 2001 From: Denis Davydov Date: Wed, 30 Aug 2017 19:56:24 +0200 Subject: [PATCH] add optional maintainers property to package (#5230) * add optional package maintainers --- lib/spack/spack/cmd/info.py | 5 +++++ lib/spack/spack/package.py | 4 ++++ var/spack/repos/builtin/packages/dealii/package.py | 2 ++ 3 files changed, 11 insertions(+) diff --git a/lib/spack/spack/cmd/info.py b/lib/spack/spack/cmd/info.py index 71ab5e3207..b7f824c091 100644 --- a/lib/spack/spack/cmd/info.py +++ b/lib/spack/spack/cmd/info.py @@ -162,6 +162,11 @@ def print_text_info(pkg): color.cprint(section_title('Homepage: ') + pkg.homepage) + if len(pkg.maintainers) > 0: + mnt = " ".join(['@@' + m for m in pkg.maintainers]) + color.cprint('') + color.cprint(section_title('Maintainers: ') + mnt) + color.cprint('') color.cprint(section_title('Preferred version: ')) diff --git a/lib/spack/spack/package.py b/lib/spack/spack/package.py index c13a566e27..b3d619f6f3 100644 --- a/lib/spack/spack/package.py +++ b/lib/spack/spack/package.py @@ -545,6 +545,10 @@ class SomePackage(Package): # Verbosity level, preserved across installs. _verbose = None + #: List of strings which contains GitHub usernames of package maintainers. + #: Do not include @ here in order not to unnecessarily ping the users. + maintainers = [] + def __init__(self, spec): # this determines how the package should be built. self.spec = spec diff --git a/var/spack/repos/builtin/packages/dealii/package.py b/var/spack/repos/builtin/packages/dealii/package.py index ab95783359..c4e999afe9 100644 --- a/var/spack/repos/builtin/packages/dealii/package.py +++ b/var/spack/repos/builtin/packages/dealii/package.py @@ -32,6 +32,8 @@ class Dealii(CMakePackage): homepage = "https://www.dealii.org" url = "https://github.com/dealii/dealii/releases/download/v8.4.1/dealii-8.4.1.tar.gz" + maintainers = ['davydden', 'jppelteret'] + # Don't add RPATHs to this package for the full build DAG. # only add for immediate deps. transitive_rpaths = False