From a30ba0b83600312cc658883b7776b141713268c3 Mon Sep 17 00:00:00 2001 From: Tom Payerle Date: Wed, 30 Dec 2020 18:54:55 -0500 Subject: [PATCH] hdf-eos2: new package (HDF for Earth Observing System using hdf5) (#20275) * hdf-eos2: new package (HDF for Earth Observing System using hdf5) * hdf-eos2: flake8 fixes * hdf-eos2: fix to support Fortran Need the compilation flag -Df2cFortran to allow support for Fortran codes --- .../hdf-eos2.nondarwin-no-single_module.patch | 27 +++++ .../builtin/packages/hdf-eos2/package.py | 99 +++++++++++++++++++ 2 files changed, 126 insertions(+) create mode 100644 var/spack/repos/builtin/packages/hdf-eos2/hdf-eos2.nondarwin-no-single_module.patch create mode 100644 var/spack/repos/builtin/packages/hdf-eos2/package.py diff --git a/var/spack/repos/builtin/packages/hdf-eos2/hdf-eos2.nondarwin-no-single_module.patch b/var/spack/repos/builtin/packages/hdf-eos2/hdf-eos2.nondarwin-no-single_module.patch new file mode 100644 index 0000000000..35a1736802 --- /dev/null +++ b/var/spack/repos/builtin/packages/hdf-eos2/hdf-eos2.nondarwin-no-single_module.patch @@ -0,0 +1,27 @@ +# This patch removes the default(?) setting of passing -single_module +# flag to the loader. From what I can gather, only the Darwin loader +# supports that, so this patch allows building on non-Darwin systems +diff -Naur spack-src/src/Makefile.am spack-src.patched/src/Makefile.am +--- spack-src/src/Makefile.am 2008-02-19 13:43:18.000000000 -0500 ++++ spack-src.patched/src/Makefile.am 2020-12-02 11:11:52.780822127 -0500 +@@ -6,7 +6,7 @@ + INCLUDES=-I$(top_srcdir)/include/ + + # Set LDFLAGS to alow the HDF-EOS library to use extern variables from HDF4 +-LDFLAGS=-Wl,-single_module ++#LDFLAGS=-Wl,-single_module + + # Build HDF-EOS2 + lib_LTLIBRARIES=libhdfeos.la +diff -Naur spack-src/src/Makefile.in spack-src.patched/src/Makefile.in +--- spack-src/src/Makefile.in 2009-05-19 12:12:34.000000000 -0400 ++++ spack-src.patched/src/Makefile.in 2020-12-02 11:12:06.686234377 -0500 +@@ -126,7 +126,7 @@ + INSTALL_STRIP_PROGRAM = @INSTALL_STRIP_PROGRAM@ + + # Set LDFLAGS to alow the HDF-EOS library to use extern variables from HDF4 +-LDFLAGS = -Wl,-single_module ++#LDFLAGS = -Wl,-single_module + LIBOBJS = @LIBOBJS@ + LIBS = @LIBS@ + LIBTOOL = @LIBTOOL@ diff --git a/var/spack/repos/builtin/packages/hdf-eos2/package.py b/var/spack/repos/builtin/packages/hdf-eos2/package.py new file mode 100644 index 0000000000..ac6d353584 --- /dev/null +++ b/var/spack/repos/builtin/packages/hdf-eos2/package.py @@ -0,0 +1,99 @@ +# Copyright 2013-2020 Lawrence Livermore National Security, LLC and other +# Spack Project Developers. See the top-level COPYRIGHT file for details. +# +# SPDX-License-Identifier: (Apache-2.0 OR MIT) + +from spack import * +import sys + + +class HdfEos2(AutotoolsPackage): + """HDF-EOS (Hierarchical Data Format - Earth Observing System) is a + self-describing file format based upon HDF for standard data products + that are derived from EOS missions. HDF-EOS2 is based upon HDF4. + """ + + homepage = "https://hdfeos.org" + # The download URLs are messing, and include sha256 checksum. + # This is just a template. See version_list and url_for_version below + # Template for url_for_version. 0 is sha256 checksum, 1 is filename + url = "https://git.earthdata.nasa.gov/rest/git-lfs/storage/DAS/hdfeos/{0}?response-content-disposition=attachment%3B%20filename%3D%22{1}%22%3B%20filename*%3Dutf-8%27%27{1}" + + # Crazy URL scheme, differing with each version, and including the + # sha256 checksum in the URL. Yuck + # The data in version_list is used to generate versions and urls + # In basename expansions, 0 is raw version, + # 1 is for version with dots => underscores + version_list = [ + {'version': '2.20v1.00', + 'sha256': 'cb0f900d2732ab01e51284d6c9e90d0e852d61bba9bce3b43af0430ab5414903', + 'basename': 'HDF-EOS{0}.tar.Z'}, + {'version': '2.19b', + 'sha256': 'a69993508dbf5fa6120bac3c906ab26f1ad277348dfc2c891305023cfdf5dc9d', + 'basename': 'hdfeos{1}.zip'} + ] + + for vrec in version_list: + ver = vrec['version'] + sha256 = vrec['sha256'] + version(ver, sha256=sha256) + + variant('shared', default=True, + description='Build shared libraries (can be used with +static)') + variant('static', default=True, + description='Build static libraries (can be used with +shared)') + + conflicts('~static', when='~shared', + msg='At least one of +static or +shared must be set') + + # Build dependencies + depends_on('hdf') + + # The standard Makefile.am, etc. add a --single_module flag to LDFLAGS + # to pass to the linker. + # That appears to be only recognized by the Darwin linker, remove it + # if we are not running on darwin/ + if sys.platform != "darwin": + patch('hdf-eos2.nondarwin-no-single_module.patch') + + def url_for_version(self, version): + vrec = [x for x in self.version_list + if x['version'] == version.dotted.string] + if vrec: + fname = vrec[0]['basename'].format(version.dotted, + version.underscored) + sha256 = vrec[0]['sha256'] + myurl = self.url.format(sha256, fname) + return myurl + else: + sys.exit('ERROR: cannot generate URL for version {0};' + 'version/checksum not found in version_list'.format( + version)) + + def configure_args(self): + extra_args = [] + + # Package really wants h4cc to be used + extra_args.append('CC={0}/bin/h4cc -Df2cFortran'.format( + self.spec['hdf'].prefix)) + + # We always build PIC code + extra_args.append('--with-pic') + + # Set shared/static appropriately + extra_args.extend(self.enable_or_disable('shared')) + extra_args.extend(self.enable_or_disable('static')) + + # Provide config args for dependencies + extra_args.append('--with-hdf4={0}'.format(self.spec['hdf'].prefix)) + if self.spec['jpeg']: + extra_args.append('--with-jpeg={0}'.format( + self.spec['jpeg'].prefix)) + if self.spec['zlib']: + extra_args.append('--with-zlib={0}'.format( + self.spec['zlib'].prefix)) + if self.spec['szip']: + extra_args.append('--with-szlib={0}'.format( + self.spec['szip'].prefix)) + + return extra_args