hlrs-software-stack/spack
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

rocm-cmake: remove ldconfig variant (#29508)

Browse source 
* rocm-cmake: remove ldconfig variant

The packages built for `rocm-cmake~ldconfig` and `rocm-cmake+ldconfig`
are identical, so the variant is unnecessary.

The `ROCM_DISABLE_LDCONFIG` option changes how `rocm_create_package`
generates DEB and RPM packages with CPack. rocm-cmake itself uses
`rocm_create_package`, however, this option is has no effect because
Spack does not build the CPack packages. It is also unnecessary on
rocm-cmake, because rocm-cmake does not contain any shared libraries
for ldconfig to configure. The rocm-cmake package is purely composed
of CMake scripts.

* Tighten CMake version dependency

* Improve package description
This commit is contained in:
Cory Bloor 2022-03-31 19:34:11 -06:00 committed by GitHub
parent 88b1bf751d
commit 9a977cb694
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
var/spack/repos/builtin/packages/rocm-cmake/package.py
View file

@ -8,8 +8,8 @@
class RocmCmake(CMakePackage):
"""ROCM cmake modules provides cmake modules for common build tasks
needed for the ROCM software stack"""
"""rocm-cmake provides CMake modules for common build tasks
in the ROCm software stack"""
homepage = "https://github.com/RadeonOpenCompute/rocm-cmake"
git = "https://github.com/RadeonOpenCompute/rocm-cmake.git"
@ -35,11 +35,6 @@ class RocmCmake(CMakePackage):
version('3.5.0', sha256='5fc09e168879823160f5fdf4fd1ace2702d36545bf733e8005ed4ca18c3e910f', deprecated=True)
variant('build_type', default='Release', values=("Release", "Debug", "RelWithDebInfo"), description='CMake build type')
variant('ldconfig', default=True, description='ROCm ldconfig')
depends_on('cmake@3:', type='build')
def cmake_args(self):
return [
self.define_from_variant('ROCM_DISABLE_LDCONFIG', 'ldconfig')
]
depends_on('cmake@3.6:', type='build', when='@4.1.0:')