hlrs-software-stack/spack
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

NCCL should not be dependent on ROCm builds since RCCL is used instead. (#32461)

Browse source 
Allow the nccl flag to be specified even for ROCm builds so that NCCL kernels are included in the build.

In this case the NCCL kernels will use RCCL as the backend implementation.
This commit is contained in:
rsanthanam-amd 2022-09-19 15:02:02 -05:00 committed by GitHub
parent 13d870157f
commit 8f8205af88
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
var/spack/repos/builtin/packages/py-tensorflow/package.py
View file

@ -291,7 +291,7 @@ class PyTensorflow(Package, CudaPackage, ROCmPackage):
depends_on("rocblas")
depends_on("rocfft")
depends_on("hipfft")
depends_on("rccl")
depends_on("rccl", when="+nccl")
depends_on("hipsparse")
depends_on("hipcub")
depends_on("rocsolver")
@ -348,7 +348,7 @@ class PyTensorflow(Package, CudaPackage, ROCmPackage):
depends_on("cudnn@:6", when="@0.5:0.6 +cuda")
depends_on("cudnn@:7", when="@0.7:2.2 +cuda")
# depends_on('tensorrt', when='+tensorrt')
depends_on("nccl", when="+nccl")
depends_on("nccl", when="+nccl+cuda")
depends_on("mpi", when="+mpi")
# depends_on('android-ndk@10:18', when='+android')
# depends_on('android-sdk', when='+android')
@ -418,7 +418,7 @@ class PyTensorflow(Package, CudaPackage, ROCmPackage):
msg="Currently TensorRT is only supported on Linux platform",
)
conflicts("+nccl", when="@:1.7")
conflicts("+nccl", when="~cuda")
conflicts("+nccl", when="~cuda~rocm")
conflicts(
"+nccl", when="platform=darwin", msg="Currently NCCL is only supported on Linux platform"
)