hlrs-software-stack/spack
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Improve error message when an unknown compiler is requested (#43143)

Browse source 
Fixes #43141
This commit is contained in:
Massimiliano Culpo 2024-03-14 21:47:56 +01:00 committed by GitHub
parent ec517b40e9
commit 8f56eb620f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 18 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lib/spack/spack/solver/asp.py
View file

@ -823,11 +823,12 @@ def on_model(model):
print("Statistics:") print("Statistics:")
pprint.pprint(self.control.statistics) pprint.pprint(self.control.statistics)
if result.unsolved_specs and setup.concretize_everything: if result.satisfiable and result.unsolved_specs and setup.concretize_everything:
unsolved_str = Result.format_unsolved(result.unsolved_specs) unsolved_str = Result.format_unsolved(result.unsolved_specs)
raise InternalConcretizerError( raise InternalConcretizerError(
"Internal Spack error: the solver completed but produced specs" "Internal Spack error: the solver completed but produced specs"
f" that do not satisfy the request.\n\t{unsolved_str}" " that do not satisfy the request. Please report a bug at "
f"https://github.com/spack/spack/issues\n\t{unsolved_str}"
) )
return result, timer, self.control.statistics return result, timer, self.control.statistics

10
lib/spack/spack/solver/concretize.lp
View file

@ -1172,11 +1172,13 @@ attr("node_compiler_version_satisfies", PackageNode, Compiler, Constraint)
% If the compiler version was set from the command line, % If the compiler version was set from the command line,
% respect it verbatim % respect it verbatim
:- attr("node_compiler_version_set", PackageNode, Compiler, Version), error(100, "Cannot set the required compiler: {2}%{0}@{1}", Compiler, Version, Package)
not attr("node_compiler_version", PackageNode, Compiler, Version). :- attr("node_compiler_version_set", node(X, Package), Compiler, Version),
not attr("node_compiler_version", node(X, Package), Compiler, Version).
:- attr("node_compiler_set", PackageNode, Compiler), error(100, "Cannot set the required compiler: {1}%{0}", Compiler, Package)
not attr("node_compiler_version", PackageNode, Compiler, _). :- attr("node_compiler_set", node(X, Package), Compiler),
not attr("node_compiler_version", node(X, Package), Compiler, _).
% Cannot select a compiler if it is not supported on the OS % Cannot select a compiler if it is not supported on the OS
% Compilers that are explicitly marked as allowed % Compilers that are explicitly marked as allowed

9
lib/spack/spack/test/concretize.py
View file

@ -2114,6 +2114,15 @@ def test_unsolved_specs_raises_error(self, monkeypatch, mock_packages, config):
): ):
solver.driver.solve(setup, specs, reuse=[]) solver.driver.solve(setup, specs, reuse=[])
@pytest.mark.regression("43141")
@pytest.mark.only_clingo("Use case not supported by the original concretizer")
def test_clear_error_when_unknown_compiler_requested(self, mock_packages, config):
"""Tests that the solver can report a case where the compiler cannot be set"""
with pytest.raises(
spack.error.UnsatisfiableSpecError, match="Cannot set the required compiler: a%foo"
):
Spec("a %foo").concretized()
@pytest.mark.regression("36339") @pytest.mark.regression("36339")
def test_compiler_match_constraints_when_selected(self): def test_compiler_match_constraints_when_selected(self):
"""Test that, when multiple compilers with the same name are in the configuration """Test that, when multiple compilers with the same name are in the configuration