From 7f2cedd31fa83e404c9701d93c9496d6d1824e4e Mon Sep 17 00:00:00 2001 From: Harmen Stoppels Date: Tue, 30 Apr 2024 13:55:48 +0200 Subject: [PATCH] hack: drop glibc and musl in old concretizer (#43914) The old concretizer creates a cyclic graph when expanding virtuals for `iconv`, which is a bug. This hack drops glibc and musl as possible providers for `iconv` in the old concretizer to work around it. --- lib/spack/spack/concretize.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/spack/spack/concretize.py b/lib/spack/spack/concretize.py index e1f1170b91..b311d777f4 100644 --- a/lib/spack/spack/concretize.py +++ b/lib/spack/spack/concretize.py @@ -74,6 +74,10 @@ class Concretizer: #: during concretization. Used for testing and for mirror creation check_for_compiler_existence = None + #: Packages that the old concretizer cannot deal with correctly, and cannot build anyway. + #: Those will not be considered as providers for virtuals. + non_buildable_packages = {"glibc", "musl"} + def __init__(self, abstract_spec=None): if Concretizer.check_for_compiler_existence is None: Concretizer.check_for_compiler_existence = not spack.config.get( @@ -113,7 +117,11 @@ def _valid_virtuals_and_externals(self, spec): pref_key = lambda spec: 0 # no-op pref key if spec.virtual: - candidates = spack.repo.PATH.providers_for(spec) + candidates = [ + s + for s in spack.repo.PATH.providers_for(spec) + if s.name not in self.non_buildable_packages + ] if not candidates: raise spack.error.UnsatisfiableProviderSpecError(candidates[0], spec)