hlrs-software-stack/spack
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Open3D: use Spack-installed 3rd party deps when possible (#28422)

Browse source
This commit is contained in:
Adam J. Stewart 2022-01-17 05:54:22 -06:00 committed by GitHub
parent e7c9f05cd9
commit 6c4e765f40
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
var/spack/repos/builtin/packages/open3d/package.py
View file

@ -23,18 +23,19 @@ class Open3d(CMakePackage, CudaPackage):
depends_on('cmake@3.19:', type='build') depends_on('cmake@3.19:', type='build')
# https://github.com/isl-org/Open3D/issues/3762 # https://github.com/isl-org/Open3D/issues/3762
depends_on('llvm') # https://github.com/isl-org/Open3D/issues/4570
# depends_on('eigen') depends_on('llvm@7:+clang+libcxx')
# depends_on('flann') depends_on('eigen')
depends_on('flann')
# depends_on('fmt') # depends_on('fmt')
# depends_on('glew') depends_on('glew')
# depends_on('glfw') depends_on('glfw')
# depends_on('imgui') # depends_on('imgui')
# depends_on('jpeg') depends_on('jpeg')
# depends_on('liblzf') # depends_on('liblzf')
# depends_on('libpng') depends_on('libpng')
# depends_on('py-pybind11') depends_on('py-pybind11')
# depends_on('qhull') depends_on('qhull')
# depends_on('tinygltf') # depends_on('tinygltf')
# depends_on('tinyobjloader') # depends_on('tinyobjloader')
@ -61,21 +62,23 @@ def cmake_args(self):
self.define('BUILD_UNIT_TESTS', self.run_tests), self.define('BUILD_UNIT_TESTS', self.run_tests),
self.define_from_variant('BUILD_PYTHON_MODULE', 'python'), self.define_from_variant('BUILD_PYTHON_MODULE', 'python'),
self.define_from_variant('BUILD_CUDA_MODULE', 'cuda'), self.define_from_variant('BUILD_CUDA_MODULE', 'cuda'),
# https://github.com/isl-org/Open3D/issues/4570
# self.define('BUILD_FILAMENT_FROM_SOURCE', 'ON'),
# Use Spack-installed dependencies instead of vendored dependencies # Use Spack-installed dependencies instead of vendored dependencies
# Numerous issues with using externally installed dependencies: # Numerous issues with using externally installed dependencies:
# https://github.com/isl-org/Open3D/issues/4333 # https://github.com/isl-org/Open3D/issues/4333
# https://github.com/isl-org/Open3D/issues/4360 # https://github.com/isl-org/Open3D/issues/4360
# self.define('USE_SYSTEM_EIGEN3', True), self.define('USE_SYSTEM_EIGEN3', True),
# self.define('USE_SYSTEM_FLANN', True), self.define('USE_SYSTEM_FLANN', True),
# self.define('USE_SYSTEM_FMT', True), # self.define('USE_SYSTEM_FMT', True),
# self.define('USE_SYSTEM_GLEW', True), self.define('USE_SYSTEM_GLEW', True),
# self.define('USE_SYSTEM_GLFW', True), self.define('USE_SYSTEM_GLFW', True),
# self.define('USE_SYSTEM_IMGUI', True), # self.define('USE_SYSTEM_IMGUI', True),
# self.define('USE_SYSTEM_JPEG', True), self.define('USE_SYSTEM_JPEG', True),
# self.define('USE_SYSTEM_LIBLZF', True), # self.define('USE_SYSTEM_LIBLZF', True),
# self.define('USE_SYSTEM_PNG', True), self.define('USE_SYSTEM_PNG', True),
# self.define('USE_SYSTEM_PYBIND11', True), self.define('USE_SYSTEM_PYBIND11', True),
# self.define('USE_SYSTEM_QHULL', True), self.define('USE_SYSTEM_QHULL', True),
# self.define('USE_SYSTEM_TINYGLTF', True), # self.define('USE_SYSTEM_TINYGLTF', True),
# self.define('USE_SYSTEM_TINYOBJLOADER', True), # self.define('USE_SYSTEM_TINYOBJLOADER', True),
] ]