From 5abf29c971913d05808173ba46c2d8bce4ddc0c3 Mon Sep 17 00:00:00 2001 From: Peter Scheibel Date: Thu, 24 Jan 2019 21:29:21 -0600 Subject: [PATCH] Environments: fix bug for install of external packages (#10437) "spack install" will install all packages added to the current environment. When this included external packages, the environment update would fail because it would attempt to copy log files that were only generated if Spack handled the install itself. This skips that step for external packages. --- lib/spack/spack/environment.py | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/spack/spack/environment.py b/lib/spack/spack/environment.py index 49a71d37b4..57a7f8c454 100644 --- a/lib/spack/spack/environment.py +++ b/lib/spack/spack/environment.py @@ -663,6 +663,7 @@ def install_all(self, args=None): with fs.working_dir(self.path): spec.package.do_install(**kwargs) + if not spec.external: # Link the resulting log file into logs dir build_log_link = os.path.join( log_path, '%s-%s.log' % (spec.name, spec.dag_hash(7)))