hlrs-software-stack/spack
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Retiring as PythonPackage maintainer (#43091)

Browse source
This commit is contained in:
Adam J. Stewart 2024-03-08 18:29:24 +01:00 committed by GitHub
parent ee1fa3e50c
commit 52f57c90eb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 4 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/spack/spack/build_systems/python.py
View file

@ -27,7 +27,7 @@
import spack.package_base import spack.package_base
import spack.spec import spack.spec
import spack.store import spack.store
from spack.directives import build_system, depends_on, extends, maintainers from spack.directives import build_system, depends_on, extends
from spack.error import NoHeadersError, NoLibrariesError from spack.error import NoHeadersError, NoLibrariesError
from spack.install_test import test_part from spack.install_test import test_part
from spack.spec import Spec from spack.spec import Spec
@ -56,8 +56,6 @@ def _flatten_dict(dictionary: Mapping[str, object]) -> Iterable[str]:
class PythonExtension(spack.package_base.PackageBase): class PythonExtension(spack.package_base.PackageBase):
maintainers("adamjstewart")
@property @property
def import_modules(self) -> Iterable[str]: def import_modules(self) -> Iterable[str]:
"""Names of modules that the Python package provides. """Names of modules that the Python package provides.

14
lib/spack/spack/test/cmd/maintainers.py
View file

@ -12,13 +12,7 @@
maintainers = spack.main.SpackCommand("maintainers") maintainers = spack.main.SpackCommand("maintainers")
MAINTAINED_PACKAGES = [ MAINTAINED_PACKAGES = ["maintainers-1", "maintainers-2", "maintainers-3", "py-extension1"]
"maintainers-1",
"maintainers-2",
"maintainers-3",
"py-extension1",
"py-extension2",
]
def split(output): def split(output):
@ -53,11 +47,8 @@ def test_all(mock_packages, capfd):
"user2,", "user2,",
"user3", "user3",
"py-extension1:", "py-extension1:",
"adamjstewart,",
"user1,", "user1,",
"user2", "user2",
"py-extension2:",
"adamjstewart",
] ]
with capfd.disabled(): with capfd.disabled():
@ -69,9 +60,6 @@ def test_all_by_user(mock_packages, capfd):
with capfd.disabled(): with capfd.disabled():
out = split(maintainers("--all", "--by-user")) out = split(maintainers("--all", "--by-user"))
assert out == [ assert out == [
"adamjstewart:",
"py-extension1,",
"py-extension2",
"user0:", "user0:",
"maintainers-3", "maintainers-3",
"user1:", "user1:",

2
lib/spack/spack/test/data/unparse/py-torch.txt
View file

@ -24,8 +24,6 @@ class PyTorch(PythonPackage, CudaPackage):
homepage = "https://pytorch.org/" homepage = "https://pytorch.org/"
git = "https://github.com/pytorch/pytorch.git" git = "https://github.com/pytorch/pytorch.git"
maintainers("adamjstewart")
# Exact set of modules is version- and variant-specific, just attempt to import the # Exact set of modules is version- and variant-specific, just attempt to import the
# core libraries to ensure that the package was successfully installed. # core libraries to ensure that the package was successfully installed.
import_modules = ["torch", "torch.autograd", "torch.nn", "torch.utils"] import_modules = ["torch", "torch.autograd", "torch.nn", "torch.utils"]

2
lib/spack/spack/test/directives.py
View file

@ -79,7 +79,7 @@ def test_error_on_anonymous_dependency(config, mock_packages):
[ [
("maintainers-1", ["user1", "user2"]), ("maintainers-1", ["user1", "user2"]),
# Extends PythonPackage # Extends PythonPackage
("py-extension1", ["adamjstewart", "user1", "user2"]), ("py-extension1", ["user1", "user2"]),
# Extends maintainers-1 # Extends maintainers-1
("maintainers-3", ["user0", "user1", "user2", "user3"]), ("maintainers-3", ["user0", "user1", "user2", "user3"]),
], ],

2
var/spack/repos/builtin/packages/python/package.py
View file

@ -33,7 +33,7 @@ class Python(Package):
list_depth = 1 list_depth = 1
tags = ["windows", "build-tools"] tags = ["windows", "build-tools"]
maintainers("adamjstewart", "skosukhin", "scheibelp") maintainers("skosukhin", "scheibelp")
phases = ["configure", "build", "install"] phases = ["configure", "build", "install"]