Retiring as PythonPackage maintainer (#43091)
This commit is contained in:
parent
ee1fa3e50c
commit
52f57c90eb
5 changed files with 4 additions and 20 deletions
|
@ -27,7 +27,7 @@
|
|||
import spack.package_base
|
||||
import spack.spec
|
||||
import spack.store
|
||||
from spack.directives import build_system, depends_on, extends, maintainers
|
||||
from spack.directives import build_system, depends_on, extends
|
||||
from spack.error import NoHeadersError, NoLibrariesError
|
||||
from spack.install_test import test_part
|
||||
from spack.spec import Spec
|
||||
|
@ -56,8 +56,6 @@ def _flatten_dict(dictionary: Mapping[str, object]) -> Iterable[str]:
|
|||
|
||||
|
||||
class PythonExtension(spack.package_base.PackageBase):
|
||||
maintainers("adamjstewart")
|
||||
|
||||
@property
|
||||
def import_modules(self) -> Iterable[str]:
|
||||
"""Names of modules that the Python package provides.
|
||||
|
|
|
@ -12,13 +12,7 @@
|
|||
|
||||
maintainers = spack.main.SpackCommand("maintainers")
|
||||
|
||||
MAINTAINED_PACKAGES = [
|
||||
"maintainers-1",
|
||||
"maintainers-2",
|
||||
"maintainers-3",
|
||||
"py-extension1",
|
||||
"py-extension2",
|
||||
]
|
||||
MAINTAINED_PACKAGES = ["maintainers-1", "maintainers-2", "maintainers-3", "py-extension1"]
|
||||
|
||||
|
||||
def split(output):
|
||||
|
@ -53,11 +47,8 @@ def test_all(mock_packages, capfd):
|
|||
"user2,",
|
||||
"user3",
|
||||
"py-extension1:",
|
||||
"adamjstewart,",
|
||||
"user1,",
|
||||
"user2",
|
||||
"py-extension2:",
|
||||
"adamjstewart",
|
||||
]
|
||||
|
||||
with capfd.disabled():
|
||||
|
@ -69,9 +60,6 @@ def test_all_by_user(mock_packages, capfd):
|
|||
with capfd.disabled():
|
||||
out = split(maintainers("--all", "--by-user"))
|
||||
assert out == [
|
||||
"adamjstewart:",
|
||||
"py-extension1,",
|
||||
"py-extension2",
|
||||
"user0:",
|
||||
"maintainers-3",
|
||||
"user1:",
|
||||
|
|
|
@ -24,8 +24,6 @@ class PyTorch(PythonPackage, CudaPackage):
|
|||
homepage = "https://pytorch.org/"
|
||||
git = "https://github.com/pytorch/pytorch.git"
|
||||
|
||||
maintainers("adamjstewart")
|
||||
|
||||
# Exact set of modules is version- and variant-specific, just attempt to import the
|
||||
# core libraries to ensure that the package was successfully installed.
|
||||
import_modules = ["torch", "torch.autograd", "torch.nn", "torch.utils"]
|
||||
|
|
|
@ -79,7 +79,7 @@ def test_error_on_anonymous_dependency(config, mock_packages):
|
|||
[
|
||||
("maintainers-1", ["user1", "user2"]),
|
||||
# Extends PythonPackage
|
||||
("py-extension1", ["adamjstewart", "user1", "user2"]),
|
||||
("py-extension1", ["user1", "user2"]),
|
||||
# Extends maintainers-1
|
||||
("maintainers-3", ["user0", "user1", "user2", "user3"]),
|
||||
],
|
||||
|
|
|
@ -33,7 +33,7 @@ class Python(Package):
|
|||
list_depth = 1
|
||||
tags = ["windows", "build-tools"]
|
||||
|
||||
maintainers("adamjstewart", "skosukhin", "scheibelp")
|
||||
maintainers("skosukhin", "scheibelp")
|
||||
|
||||
phases = ["configure", "build", "install"]
|
||||
|
||||
|
|
Loading…
Reference in a new issue