fastx-toolkit builds with newer gcc's (#10228)
There's a missing break in a switch statement that newer gcc's dislike. Our #4696 simply disallowed newer gcc's. This fixes the problem instead. It's been [PR'ed upstream](https://github.com/agordon/fastx_toolkit/pull/22). Tested with gcc@5.5.0 and gcc@8.2.0 on CentOS.
This commit is contained in:
parent
7aeff18b6f
commit
51fbd315e9
2 changed files with 13 additions and 1 deletions
|
@ -17,4 +17,5 @@ class FastxToolkit(AutotoolsPackage):
|
|||
|
||||
depends_on('libgtextutils')
|
||||
|
||||
conflicts('%gcc@7.1.0:')
|
||||
# patch implicit fallthrough
|
||||
patch("pr-22.patch")
|
||||
|
|
11
var/spack/repos/builtin/packages/fastx-toolkit/pr-22.patch
Normal file
11
var/spack/repos/builtin/packages/fastx-toolkit/pr-22.patch
Normal file
|
@ -0,0 +1,11 @@
|
|||
diff -ur fastx_toolkit-0.0.14.orig/src/fasta_formatter/fasta_formatter.cpp fastx_toolkit-0.0.14/src/fasta_formatter/fasta_formatter.cpp
|
||||
--- fastx_toolkit-0.0.14.orig/src/fasta_formatter/fasta_formatter.cpp 2014-01-05 13:10:49.000000000 -0800
|
||||
+++ fastx_toolkit-0.0.14/src/fasta_formatter/fasta_formatter.cpp 2018-12-31 09:58:21.923778569 -0800
|
||||
@@ -103,6 +103,7 @@
|
||||
switch(opt) {
|
||||
case 'h':
|
||||
usage();
|
||||
+ break;
|
||||
|
||||
case 'i':
|
||||
input_filename = optarg;
|
Loading…
Reference in a new issue