hlrs-software-stack/spack
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

bugfix: spack stacks mixed dependency and non-dep constraints (#12315)

Browse source 
Spack stacks drop invalid dependencies applied to packages by a
spec_list matrix operation

Without this fix, Spack would raise an error if orthogonal dependency
constraints and non-dependency constraints were applied to the same
package by a matrix and the dependency constraint was invalid for
that package. This is an error, fixed by this PR.

An example failing configuration:

spack:
  definitions:
  - packages: [libelf, hdf5+mpi]
  - compilers: ['%gcc']
  - mpis: [^openmpi]

  specs:
  - matrix:
    - $packages
    - $compilers
    - $mpis
This commit is contained in:
Greg Becker 2019-08-07 18:34:41 -07:00 committed by Peter Scheibel
parent a791234676
commit 36fbd6cf4c
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/spack/spack/environment.py
View file

@ -1346,7 +1346,7 @@ def _concretize_from_constraints(spec_constraints):
for d in invalid_msg.split()
if d != 'or']
invalid_deps = [c for c in spec_constraints
if any(c.satisfies(invd)
if any(c.satisfies(invd, strict=True)
for invd in invalid_deps_string)]
if len(invalid_deps) != len(invalid_deps_string):
raise e