From 270ba1096285032e33c62fa20236e7ae0bd3120c Mon Sep 17 00:00:00 2001 From: Massimiliano Culpo Date: Wed, 24 Nov 2021 23:20:11 +0100 Subject: [PATCH] spack flake8: remove deprecated command (#27290) The "spack flake8" command wwas deprecated in favor of "spack style". The deprecation wwarning is in the 0.17.X series, so removing it for v0.18.x --- lib/spack/spack/cmd/flake8.py | 25 ------------------------- share/spack/spack-completion.bash | 11 +---------- 2 files changed, 1 insertion(+), 35 deletions(-) delete mode 100644 lib/spack/spack/cmd/flake8.py diff --git a/lib/spack/spack/cmd/flake8.py b/lib/spack/spack/cmd/flake8.py deleted file mode 100644 index 0579cb674a..0000000000 --- a/lib/spack/spack/cmd/flake8.py +++ /dev/null @@ -1,25 +0,0 @@ -# Copyright 2013-2021 Lawrence Livermore National Security, LLC and other -# Spack Project Developers. See the top-level COPYRIGHT file for details. -# -# SPDX-License-Identifier: (Apache-2.0 OR MIT) - -from __future__ import print_function - -import llnl.util.tty as tty - -import spack.cmd.style - -description = "alias for spack style (deprecated)" -section = spack.cmd.style.section -level = spack.cmd.style.level - - -def setup_parser(subparser): - spack.cmd.style.setup_parser(subparser) - - -def flake8(parser, args): - tty.warn( - "spack flake8 is deprecated", "please use `spack style` to run style checks" - ) - return spack.cmd.style.style(parser, args) diff --git a/share/spack/spack-completion.bash b/share/spack/spack-completion.bash index b0d9d70f3f..457fc24374 100755 --- a/share/spack/spack-completion.bash +++ b/share/spack/spack-completion.bash @@ -337,7 +337,7 @@ _spack() { then SPACK_COMPREPLY="-h --help -H --all-help --color -c --config -C --config-scope -d --debug --timestamp --pdb -e --env -D --env-dir -E --no-env --use-env-repo -k --insecure -l --enable-locks -L --disable-locks -m --mock -p --profile --sorted-profile --lines -v --verbose --stacktrace -V --version --print-shell-vars" else - SPACK_COMPREPLY="activate add analyze arch audit blame bootstrap build-env buildcache cd checksum ci clean clone commands compiler compilers concretize config containerize create deactivate debug dependencies dependents deprecate dev-build develop diff docs edit env extensions external fetch find flake8 gc gpg graph help info install license list load location log-parse maintainers mark mirror module monitor patch pkg providers pydoc python reindex remove rm repo resource restage solve spec stage style tags test test-env tutorial undevelop uninstall unit-test unload url verify versions view" + SPACK_COMPREPLY="activate add analyze arch audit blame bootstrap build-env buildcache cd checksum ci clean clone commands compiler compilers concretize config containerize create deactivate debug dependencies dependents deprecate dev-build develop diff docs edit env extensions external fetch find gc gpg graph help info install license list load location log-parse maintainers mark mirror module monitor patch pkg providers pydoc python reindex remove rm repo resource restage solve spec stage style tags test test-env tutorial undevelop uninstall unit-test unload url verify versions view" fi } @@ -1048,15 +1048,6 @@ _spack_find() { fi } -_spack_flake8() { - if $list_options - then - SPACK_COMPREPLY="-h --help -b --base -a --all -r --root-relative -U --no-untracked -f --fix --no-isort --no-flake8 --no-mypy --black --root" - else - SPACK_COMPREPLY="" - fi -} - _spack_gc() { SPACK_COMPREPLY="-h --help -y --yes-to-all" }