hlrs-software-stack/spack
7
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix long-standing multimethod test error.

Browse source 
- New inclusive version ranges from git-fetching branch enable a fix.
- Can now write :1 to include 1.3, 1.4, etc.
  - couldn't do this before so provides() was weird.
This commit is contained in:
Todd Gamblin 2014-10-27 20:02:24 -07:00
parent d98beeec31
commit 1c4948e1b0
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/spack/spack/test/multimethod.py
View file

@ -73,11 +73,11 @@ def test_mpi_version(self):
def test_undefined_mpi_version(self): def test_undefined_mpi_version(self):
# This currently fails because provides() doesn't do
# the right thing undefined version ranges.
# TODO: fix this.
pkg = spack.db.get('multimethod^mpich@0.4') pkg = spack.db.get('multimethod^mpich@0.4')
self.assertEqual(pkg.mpi_version(), 0) self.assertEqual(pkg.mpi_version(), 1)
pkg = spack.db.get('multimethod^mpich@1.4')
self.assertEqual(pkg.mpi_version(), 1)
def test_default_works(self): def test_default_works(self):

2
var/spack/mock_packages/mpich/package.py
View file

@ -37,7 +37,7 @@ class Mpich(Package):
version('3.0', 'foobarbaz') version('3.0', 'foobarbaz')
provides('mpi@:3', when='@3:') provides('mpi@:3', when='@3:')
provides('mpi@:1', when='@1:') provides('mpi@:1', when='@:1')
def install(self, spec, prefix): def install(self, spec, prefix):
pass pass