Reorder workflow execution in GHA (#32183)
This patchset refactors our GitHub actions into a single top-level ci workflow that
invokes a series of reusable actions. The main goal of this is to be able to easily
control which tests run and in what order based on the success or failure of top-level
prechecks. Our previous workflows ran in three sets:
* nix tests: style and verification first, then linux and macos tests if successful
* windows tests: style and verification first, then linux and macos tests if successful
* bootstrap tests
As a result, the bootstrap tests ran even if the style failed, and style and verification
had to run on two different platforms despite running identical checks. I'm relatively
sure that's because of the limitation on dependencies between steps in the jobs.
Reusable workflows allow us to run the style, verification and now audit checks once,
then depending on the results, and the files changed, run the appropriate nix, windows
and bootstrap tests. While it saves only a few minutes by itself, this makes it easier to
refactor checks to subset tests without having to replicate tests or other workflow
components in the future.
Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
2022-09-02 21:09:23 +00:00
|
|
|
name: windows
|
2022-01-25 22:29:17 +00:00
|
|
|
|
|
|
|
on:
|
Reorder workflow execution in GHA (#32183)
This patchset refactors our GitHub actions into a single top-level ci workflow that
invokes a series of reusable actions. The main goal of this is to be able to easily
control which tests run and in what order based on the success or failure of top-level
prechecks. Our previous workflows ran in three sets:
* nix tests: style and verification first, then linux and macos tests if successful
* windows tests: style and verification first, then linux and macos tests if successful
* bootstrap tests
As a result, the bootstrap tests ran even if the style failed, and style and verification
had to run on two different platforms despite running identical checks. I'm relatively
sure that's because of the limitation on dependencies between steps in the jobs.
Reusable workflows allow us to run the style, verification and now audit checks once,
then depending on the results, and the files changed, run the appropriate nix, windows
and bootstrap tests. While it saves only a few minutes by itself, this makes it easier to
refactor checks to subset tests without having to replicate tests or other workflow
components in the future.
Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
2022-09-02 21:09:23 +00:00
|
|
|
workflow_call:
|
2022-06-08 22:46:46 +00:00
|
|
|
|
|
|
|
concurrency:
|
2022-09-07 18:12:57 +00:00
|
|
|
group: windows-${{github.ref}}-${{github.event.pull_request.number || github.run_number}}
|
2022-06-08 22:46:46 +00:00
|
|
|
cancel-in-progress: true
|
|
|
|
|
2022-01-25 22:29:17 +00:00
|
|
|
defaults:
|
|
|
|
run:
|
|
|
|
shell:
|
2022-12-09 13:27:46 +00:00
|
|
|
powershell Invoke-Expression -Command "./share/spack/qa/windows_test_setup.ps1"; {0}
|
2022-01-25 22:29:17 +00:00
|
|
|
jobs:
|
Reorder workflow execution in GHA (#32183)
This patchset refactors our GitHub actions into a single top-level ci workflow that
invokes a series of reusable actions. The main goal of this is to be able to easily
control which tests run and in what order based on the success or failure of top-level
prechecks. Our previous workflows ran in three sets:
* nix tests: style and verification first, then linux and macos tests if successful
* windows tests: style and verification first, then linux and macos tests if successful
* bootstrap tests
As a result, the bootstrap tests ran even if the style failed, and style and verification
had to run on two different platforms despite running identical checks. I'm relatively
sure that's because of the limitation on dependencies between steps in the jobs.
Reusable workflows allow us to run the style, verification and now audit checks once,
then depending on the results, and the files changed, run the appropriate nix, windows
and bootstrap tests. While it saves only a few minutes by itself, this makes it easier to
refactor checks to subset tests without having to replicate tests or other workflow
components in the future.
Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
2022-09-02 21:09:23 +00:00
|
|
|
unit-tests:
|
2022-01-25 22:29:17 +00:00
|
|
|
runs-on: windows-latest
|
|
|
|
steps:
|
2023-04-15 12:37:52 +00:00
|
|
|
- uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
|
2022-01-25 22:29:17 +00:00
|
|
|
with:
|
|
|
|
fetch-depth: 0
|
2023-01-16 09:33:12 +00:00
|
|
|
- uses: actions/setup-python@d27e3f3d7c64b4bbf8e4abfb9b63b83e846e0435
|
2022-01-25 22:29:17 +00:00
|
|
|
with:
|
|
|
|
python-version: 3.9
|
|
|
|
- name: Install Python packages
|
|
|
|
run: |
|
2023-04-12 17:28:55 +00:00
|
|
|
python -m pip install --upgrade pip six pywin32 setuptools pytest-cov clingo
|
2022-01-25 22:29:17 +00:00
|
|
|
- name: Create local develop
|
|
|
|
run: |
|
2022-12-09 13:27:46 +00:00
|
|
|
./.github/workflows/setup_git.ps1
|
2022-01-25 22:29:17 +00:00
|
|
|
- name: Unit Test
|
|
|
|
run: |
|
2022-10-25 11:04:25 +00:00
|
|
|
spack unit-test -x --verbose --cov --cov-config=pyproject.toml --ignore=lib/spack/spack/test/cmd
|
2022-12-09 13:27:46 +00:00
|
|
|
./share/spack/qa/validate_last_exit.ps1
|
2022-09-16 12:38:29 +00:00
|
|
|
coverage combine -a
|
|
|
|
coverage xml
|
2023-04-12 15:28:39 +00:00
|
|
|
- uses: codecov/codecov-action@40a12dcee2df644d47232dde008099a3e9e4f865
|
2022-09-16 12:38:29 +00:00
|
|
|
with:
|
|
|
|
flags: unittests,windows
|
Reorder workflow execution in GHA (#32183)
This patchset refactors our GitHub actions into a single top-level ci workflow that
invokes a series of reusable actions. The main goal of this is to be able to easily
control which tests run and in what order based on the success or failure of top-level
prechecks. Our previous workflows ran in three sets:
* nix tests: style and verification first, then linux and macos tests if successful
* windows tests: style and verification first, then linux and macos tests if successful
* bootstrap tests
As a result, the bootstrap tests ran even if the style failed, and style and verification
had to run on two different platforms despite running identical checks. I'm relatively
sure that's because of the limitation on dependencies between steps in the jobs.
Reusable workflows allow us to run the style, verification and now audit checks once,
then depending on the results, and the files changed, run the appropriate nix, windows
and bootstrap tests. While it saves only a few minutes by itself, this makes it easier to
refactor checks to subset tests without having to replicate tests or other workflow
components in the future.
Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
2022-09-02 21:09:23 +00:00
|
|
|
unit-tests-cmd:
|
2022-01-25 22:29:17 +00:00
|
|
|
runs-on: windows-latest
|
|
|
|
steps:
|
2023-04-15 12:37:52 +00:00
|
|
|
- uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
|
2022-01-25 22:29:17 +00:00
|
|
|
with:
|
|
|
|
fetch-depth: 0
|
2023-01-16 09:33:12 +00:00
|
|
|
- uses: actions/setup-python@d27e3f3d7c64b4bbf8e4abfb9b63b83e846e0435
|
2022-01-25 22:29:17 +00:00
|
|
|
with:
|
|
|
|
python-version: 3.9
|
|
|
|
- name: Install Python packages
|
|
|
|
run: |
|
2023-04-12 17:28:55 +00:00
|
|
|
python -m pip install --upgrade pip six pywin32 setuptools coverage pytest-cov clingo
|
2022-01-25 22:29:17 +00:00
|
|
|
- name: Create local develop
|
|
|
|
run: |
|
2022-12-09 13:27:46 +00:00
|
|
|
./.github/workflows/setup_git.ps1
|
2022-01-25 22:29:17 +00:00
|
|
|
- name: Command Unit Test
|
|
|
|
run: |
|
2022-10-25 11:04:25 +00:00
|
|
|
spack unit-test -x --verbose --cov --cov-config=pyproject.toml lib/spack/spack/test/cmd
|
2022-12-09 13:27:46 +00:00
|
|
|
./share/spack/qa/validate_last_exit.ps1
|
2022-09-16 12:38:29 +00:00
|
|
|
coverage combine -a
|
|
|
|
coverage xml
|
2023-04-12 15:28:39 +00:00
|
|
|
- uses: codecov/codecov-action@40a12dcee2df644d47232dde008099a3e9e4f865
|
2022-09-16 12:38:29 +00:00
|
|
|
with:
|
|
|
|
flags: unittests,windows
|
Reorder workflow execution in GHA (#32183)
This patchset refactors our GitHub actions into a single top-level ci workflow that
invokes a series of reusable actions. The main goal of this is to be able to easily
control which tests run and in what order based on the success or failure of top-level
prechecks. Our previous workflows ran in three sets:
* nix tests: style and verification first, then linux and macos tests if successful
* windows tests: style and verification first, then linux and macos tests if successful
* bootstrap tests
As a result, the bootstrap tests ran even if the style failed, and style and verification
had to run on two different platforms despite running identical checks. I'm relatively
sure that's because of the limitation on dependencies between steps in the jobs.
Reusable workflows allow us to run the style, verification and now audit checks once,
then depending on the results, and the files changed, run the appropriate nix, windows
and bootstrap tests. While it saves only a few minutes by itself, this makes it easier to
refactor checks to subset tests without having to replicate tests or other workflow
components in the future.
Co-authored-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
2022-09-02 21:09:23 +00:00
|
|
|
build-abseil:
|
2022-01-25 22:29:17 +00:00
|
|
|
runs-on: windows-latest
|
|
|
|
steps:
|
2023-04-15 12:37:52 +00:00
|
|
|
- uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
|
2022-01-25 22:29:17 +00:00
|
|
|
with:
|
|
|
|
fetch-depth: 0
|
2023-01-16 09:33:12 +00:00
|
|
|
- uses: actions/setup-python@d27e3f3d7c64b4bbf8e4abfb9b63b83e846e0435
|
2022-01-25 22:29:17 +00:00
|
|
|
with:
|
|
|
|
python-version: 3.9
|
|
|
|
- name: Install Python packages
|
|
|
|
run: |
|
2023-04-12 17:28:55 +00:00
|
|
|
python -m pip install --upgrade pip six pywin32 setuptools coverage
|
2022-01-25 22:29:17 +00:00
|
|
|
- name: Build Test
|
|
|
|
run: |
|
|
|
|
spack compiler find
|
|
|
|
spack external find cmake
|
|
|
|
spack external find ninja
|
2022-10-31 16:36:52 +00:00
|
|
|
spack -d install abseil-cpp
|
2022-12-09 13:27:46 +00:00
|
|
|
# TODO: johnwparent - reduce the size of the installer operations
|
|
|
|
# make-installer:
|
|
|
|
# runs-on: windows-latest
|
|
|
|
# steps:
|
|
|
|
# - name: Disable Windows Symlinks
|
|
|
|
# run: |
|
|
|
|
# git config --global core.symlinks false
|
|
|
|
# shell:
|
|
|
|
# powershell
|
2023-04-15 12:37:52 +00:00
|
|
|
# - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
|
2022-12-09 13:27:46 +00:00
|
|
|
# with:
|
|
|
|
# fetch-depth: 0
|
2023-01-16 09:33:12 +00:00
|
|
|
# - uses: actions/setup-python@d27e3f3d7c64b4bbf8e4abfb9b63b83e846e0435
|
2022-12-09 13:27:46 +00:00
|
|
|
# with:
|
|
|
|
# python-version: 3.9
|
|
|
|
# - name: Install Python packages
|
|
|
|
# run: |
|
|
|
|
# python -m pip install --upgrade pip six pywin32 setuptools
|
|
|
|
# - name: Add Light and Candle to Path
|
|
|
|
# run: |
|
|
|
|
# $env:WIX >> $GITHUB_PATH
|
|
|
|
# - name: Run Installer
|
|
|
|
# run: |
|
|
|
|
# ./share/spack/qa/setup_spack_installer.ps1
|
|
|
|
# spack make-installer -s . -g SILENT pkg
|
|
|
|
# echo "installer_root=$((pwd).Path)" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf8 -Append
|
|
|
|
# env:
|
|
|
|
# ProgressPreference: SilentlyContinue
|
|
|
|
# - uses: actions/upload-artifact@83fd05a356d7e2593de66fc9913b3002723633cb
|
|
|
|
# with:
|
|
|
|
# name: Windows Spack Installer Bundle
|
|
|
|
# path: ${{ env.installer_root }}\pkg\Spack.exe
|
|
|
|
# - uses: actions/upload-artifact@83fd05a356d7e2593de66fc9913b3002723633cb
|
|
|
|
# with:
|
|
|
|
# name: Windows Spack Installer
|
|
|
|
# path: ${{ env.installer_root}}\pkg\Spack.msi
|
|
|
|
# execute-installer:
|
|
|
|
# needs: make-installer
|
|
|
|
# runs-on: windows-latest
|
|
|
|
# defaults:
|
|
|
|
# run:
|
|
|
|
# shell: pwsh
|
|
|
|
# steps:
|
2023-01-16 09:33:12 +00:00
|
|
|
# - uses: actions/setup-python@d27e3f3d7c64b4bbf8e4abfb9b63b83e846e0435
|
2022-12-09 13:27:46 +00:00
|
|
|
# with:
|
|
|
|
# python-version: 3.9
|
|
|
|
# - name: Install Python packages
|
|
|
|
# run: |
|
|
|
|
# python -m pip install --upgrade pip six pywin32 setuptools
|
|
|
|
# - name: Setup installer directory
|
|
|
|
# run: |
|
|
|
|
# mkdir -p spack_installer
|
|
|
|
# echo "spack_installer=$((pwd).Path)\spack_installer" | Out-File -FilePath $Env:GITHUB_ENV -Encoding utf8 -Append
|
|
|
|
# - uses: actions/download-artifact@v3
|
|
|
|
# with:
|
|
|
|
# name: Windows Spack Installer Bundle
|
|
|
|
# path: ${{ env.spack_installer }}
|
|
|
|
# - name: Execute Bundled Installer
|
|
|
|
# run: |
|
|
|
|
# $proc = Start-Process ${{ env.spack_installer }}\spack.exe "/install /quiet" -Passthru
|
|
|
|
# $handle = $proc.Handle # cache proc.Handle
|
|
|
|
# $proc.WaitForExit();
|
|
|
|
# $LASTEXITCODE
|
|
|
|
# env:
|
|
|
|
# ProgressPreference: SilentlyContinue
|
|
|
|
# - uses: actions/download-artifact@v3
|
|
|
|
# with:
|
|
|
|
# name: Windows Spack Installer
|
|
|
|
# path: ${{ env.spack_installer }}
|
|
|
|
# - name: Execute MSI
|
|
|
|
# run: |
|
|
|
|
# $proc = Start-Process ${{ env.spack_installer }}\spack.msi "/quiet" -Passthru
|
|
|
|
# $handle = $proc.Handle # cache proc.Handle
|
|
|
|
# $proc.WaitForExit();
|
|
|
|
# $LASTEXITCODE
|