From a9695503fc8fd625a047726b8e61362e704fe43f Mon Sep 17 00:00:00 2001 From: Hrvoje Jasak Date: Tue, 25 Aug 2015 11:12:02 +0100 Subject: [PATCH 01/15] Report patch name instead of index in debug --- .../polyPatches/constraint/ggi/ggiPolyPatch.C | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/foam/meshes/polyMesh/polyPatches/constraint/ggi/ggiPolyPatch.C b/src/foam/meshes/polyMesh/polyPatches/constraint/ggi/ggiPolyPatch.C index 23deecb82..9f5039e00 100644 --- a/src/foam/meshes/polyMesh/polyPatches/constraint/ggi/ggiPolyPatch.C +++ b/src/foam/meshes/polyMesh/polyPatches/constraint/ggi/ggiPolyPatch.C @@ -195,7 +195,8 @@ void Foam::ggiPolyPatch::calcPatchToPatch() const if (debug) { InfoIn("void ggiPolyPatch::calcPatchToPatch() const") - << "Calculating patch to patch interpolation" << endl; + << "Calculating patch to patch interpolation for patch" + << name() << endl; } // Create interpolation for zones @@ -258,6 +259,13 @@ void Foam::ggiPolyPatch::calcReconFaceCellCentres() const << abort(FatalError); } + if (debug) + { + InfoIn("void ggiPolyPatch::calcReconFaceCellCentres() const") + << "Calculating recon centres for patch" + << name() << endl; + } + // Create neighbouring face centres using interpolation if (master()) { @@ -366,7 +374,7 @@ void Foam::ggiPolyPatch::calcSendReceive() const if (debug) { Pout<< "ggiPolyPatch::calcSendReceive() const for patch " - << index() << endl; + << name() << endl; } if (!Pstream::parRun()) From 7d533e60ab4ecd8233c7ee9aeb142ad055f80c1f Mon Sep 17 00:00:00 2001 From: Hrvoje Jasak Date: Tue, 25 Aug 2015 11:12:02 +0100 Subject: [PATCH 02/15] Report patch name instead of index in debug --- .../polyPatches/constraint/ggi/ggiPolyPatch.C | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/foam/meshes/polyMesh/polyPatches/constraint/ggi/ggiPolyPatch.C b/src/foam/meshes/polyMesh/polyPatches/constraint/ggi/ggiPolyPatch.C index 9f5039e00..23deecb82 100644 --- a/src/foam/meshes/polyMesh/polyPatches/constraint/ggi/ggiPolyPatch.C +++ b/src/foam/meshes/polyMesh/polyPatches/constraint/ggi/ggiPolyPatch.C @@ -195,8 +195,7 @@ void Foam::ggiPolyPatch::calcPatchToPatch() const if (debug) { InfoIn("void ggiPolyPatch::calcPatchToPatch() const") - << "Calculating patch to patch interpolation for patch" - << name() << endl; + << "Calculating patch to patch interpolation" << endl; } // Create interpolation for zones @@ -259,13 +258,6 @@ void Foam::ggiPolyPatch::calcReconFaceCellCentres() const << abort(FatalError); } - if (debug) - { - InfoIn("void ggiPolyPatch::calcReconFaceCellCentres() const") - << "Calculating recon centres for patch" - << name() << endl; - } - // Create neighbouring face centres using interpolation if (master()) { @@ -374,7 +366,7 @@ void Foam::ggiPolyPatch::calcSendReceive() const if (debug) { Pout<< "ggiPolyPatch::calcSendReceive() const for patch " - << name() << endl; + << index() << endl; } if (!Pstream::parRun()) From 1721f8ffc0a9a79a8d82e298ed90af06f2bef16a Mon Sep 17 00:00:00 2001 From: Hrvoje Jasak Date: Thu, 3 Sep 2015 17:05:38 +0100 Subject: [PATCH 03/15] Bugfix: missing rho on dev(P). Jens Truemner --- .../compressible/RAS/LaunderGibsonRSTM/LaunderGibsonRSTM.C | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/turbulenceModels/compressible/RAS/LaunderGibsonRSTM/LaunderGibsonRSTM.C b/src/turbulenceModels/compressible/RAS/LaunderGibsonRSTM/LaunderGibsonRSTM.C index 7ce693261..d1af0a898 100644 --- a/src/turbulenceModels/compressible/RAS/LaunderGibsonRSTM/LaunderGibsonRSTM.C +++ b/src/turbulenceModels/compressible/RAS/LaunderGibsonRSTM/LaunderGibsonRSTM.C @@ -446,7 +446,7 @@ void LaunderGibsonRSTM::correct() // Change for consistency with Fluent implementation. // Emil Baric, NUMAP-FOAM 2011 // HJ, 13/Dec/2011 - - Clg2_*(dev(P) - dev(C)) + - Clg2_*(rho_*dev(P) - dev(C)) // wall reflection terms + symm From 161ad618de2dbe62f4e5a48716fb189518b841c0 Mon Sep 17 00:00:00 2001 From: Hrvoje Jasak Date: Mon, 7 Sep 2015 11:07:36 +0100 Subject: [PATCH 04/15] Formatting --- .../basicSymmetry/basicSymmetryFvPatchScalarField.C | 9 ++++++--- .../derived/advective/advectiveFvPatchField.C | 5 ++++- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/finiteVolume/fields/fvPatchFields/basic/basicSymmetry/basicSymmetryFvPatchScalarField.C b/src/finiteVolume/fields/fvPatchFields/basic/basicSymmetry/basicSymmetryFvPatchScalarField.C index 3fb6d398a..b40e7e713 100644 --- a/src/finiteVolume/fields/fvPatchFields/basic/basicSymmetry/basicSymmetryFvPatchScalarField.C +++ b/src/finiteVolume/fields/fvPatchFields/basic/basicSymmetry/basicSymmetryFvPatchScalarField.C @@ -51,7 +51,8 @@ void basicSymmetryFvPatchField::evaluate(const Pstream::commsTypes) // Local typedefs typedef scalar Type; typedef outerProduct::type gradType; - typedef GeometricField gradFieldType; + typedef GeometricField + gradFieldType; if (!updated()) { @@ -141,7 +142,8 @@ tmp basicSymmetryFvPatchField::snGrad() const // Local typedefs typedef vector Type; typedef outerProduct::type gradType; - typedef GeometricField gradFieldType; + typedef GeometricField + gradFieldType; vectorField nHat = this->patch().nf(); @@ -214,7 +216,8 @@ void basicSymmetryFvPatchField::evaluate(const Pstream::commsTypes) // Local typedefs typedef vector Type; typedef outerProduct::type gradType; - typedef GeometricField gradFieldType; + typedef GeometricField + gradFieldType; if (!updated()) { diff --git a/src/finiteVolume/fields/fvPatchFields/derived/advective/advectiveFvPatchField.C b/src/finiteVolume/fields/fvPatchFields/derived/advective/advectiveFvPatchField.C index 91578d12c..f212163db 100644 --- a/src/finiteVolume/fields/fvPatchFields/derived/advective/advectiveFvPatchField.C +++ b/src/finiteVolume/fields/fvPatchFields/derived/advective/advectiveFvPatchField.C @@ -172,7 +172,10 @@ template tmp advectiveFvPatchField::advectionSpeed() const { const surfaceScalarField& phi = - this->db().objectRegistry::template lookupObject(phiName_); + this->db().objectRegistry::template lookupObject + ( + phiName_ + ); fvsPatchField phip = this->lookupPatchField ( From 4d4c7d0eed576f9d22ac5ce8391ca2ec4e043daf Mon Sep 17 00:00:00 2001 From: Hrvoje Jasak Date: Mon, 7 Sep 2015 11:08:41 +0100 Subject: [PATCH 05/15] Intel 2016 compiler porting --- .../octreeData/octreeDataTriSurfaceTreeLeaf.H | 2 +- src/surfMesh/MeshedSurface/MeshedSurface.C | 30 ++++++++++--------- 2 files changed, 17 insertions(+), 15 deletions(-) diff --git a/src/meshTools/triSurface/octreeData/octreeDataTriSurfaceTreeLeaf.H b/src/meshTools/triSurface/octreeData/octreeDataTriSurfaceTreeLeaf.H index 4887ece59..58c86adb6 100644 --- a/src/meshTools/triSurface/octreeData/octreeDataTriSurfaceTreeLeaf.H +++ b/src/meshTools/triSurface/octreeData/octreeDataTriSurfaceTreeLeaf.H @@ -45,7 +45,7 @@ namespace Foam // Forward declaration of classes class octreeDataTriSurface; -template<> inline +template<> bool treeLeaf::findNearest ( const octreeDataTriSurface& shapes, diff --git a/src/surfMesh/MeshedSurface/MeshedSurface.C b/src/surfMesh/MeshedSurface/MeshedSurface.C index a7205d8b6..5bb0cda5d 100644 --- a/src/surfMesh/MeshedSurface/MeshedSurface.C +++ b/src/surfMesh/MeshedSurface/MeshedSurface.C @@ -32,6 +32,8 @@ License #include "polyBoundaryMesh.H" #include "polyMesh.H" #include "surfMesh.H" +#include "Xfer.H" +#include "surfZone.H" #include "primitivePatch.H" #include "addToRunTimeSelectionTable.H" @@ -170,9 +172,9 @@ Foam::MeshedSurface::MeshedSurface() template Foam::MeshedSurface::MeshedSurface ( - const Xfer< pointField >& pointLst, - const Xfer< List >& faceLst, - const Xfer< surfZoneList >& zoneLst + const Xfer& pointLst, + const Xfer >& faceLst, + const Xfer& zoneLst ) : ParentType(List(), pointField()), @@ -185,8 +187,8 @@ Foam::MeshedSurface::MeshedSurface template Foam::MeshedSurface::MeshedSurface ( - const Xfer< pointField >& pointLst, - const Xfer< List >& faceLst, + const Xfer& pointLst, + const Xfer >& faceLst, const UList