Two bugfixes:

1. polyTopoChanger::changeMesh -> call to polyTopoChanger::update needs to
   happen after polyMesh::updateMesh (more specifically,
   polyBoundaryMesh::updateMesh) in order to correctly build the processor data,
2. refinement::updateMesh -> now that number 1 is fixed, point sync happens in
   updateMesh instead of setRefinement.

These two combined were responsible for hard-to-track errors in AMR + DLB
This commit is contained in:
Vuko Vukcevic 2019-02-19 22:15:16 +01:00
parent 5526c3a048
commit 7f08269ab2
5 changed files with 31 additions and 25 deletions

View file

@ -2088,7 +2088,8 @@ void Foam::polyhedralRefinement::setCellsToRefine
if (debug) if (debug)
{ {
Info<< "Added " << nAddCells << " in iteration " << nIters << nl; Info<< "Added " << nAddCells << " cells in iteration "
<< nIters << nl;
} }
} while (nAddCells > 0); } while (nAddCells > 0);
@ -2375,7 +2376,8 @@ void Foam::polyhedralRefinement::setSplitPointsToUnrefine
if (debug) if (debug)
{ {
Info<< "Removed " << nRemCells << " in iteration " << nIters << nl; Info<< "Removed " << nRemCells << " cells in iteration "
<< nIters << nl;
} }
} while (nRemCells > 0); } while (nRemCells > 0);

View file

@ -1057,6 +1057,10 @@ Foam::label Foam::refinement::faceConsistentUnrefinement
<< "This is probably because the refinement and " << "This is probably because the refinement and "
<< "unrefinement regions are very close." << nl << "unrefinement regions are very close." << nl
<< "Try increasing nUnrefinementBufferLayers. " << "Try increasing nUnrefinementBufferLayers. "
<< nl
<< "Another possibility is that you are running "
<< "with Dynamic Load Balancing, in which case "
<< "this should be fine."
<< endl; << endl;
} }
} }
@ -1443,20 +1447,6 @@ bool Foam::refinement::changeTopology() const
void Foam::refinement::setRefinement(polyTopoChange& ref) const void Foam::refinement::setRefinement(polyTopoChange& ref) const
{ {
// Make sure that the point levels are updated across coupled patches before
// setting refinement and unrefinement. Note: not sure why the sync is not
// performed correctly if I do it in updateMesh. This is a temporary
// solution, need to investigate in detail, but I assume something is not
// updated yet in that case. VV, 31/Jan/2018.
syncTools::syncPointList
(
mesh_,
pointLevel_,
maxEqOp<label>(),
0, // Null value
true // Apply separation for parallel cyclics
);
// Set refinement and unrefinement // Set refinement and unrefinement
this->setRefinementInstruction(ref); this->setRefinementInstruction(ref);
this->setUnrefinementInstruction(ref); this->setUnrefinementInstruction(ref);
@ -1610,10 +1600,21 @@ void Foam::refinement::updateMesh(const mapPolyMesh& map)
} }
} }
// Note: new point level is going to be synced at processor boundaries just // Sync the new point level. Note: here, we assume that the call to
// before the next step in setRefinement. Need to investigate why the sync // updateMesh happened after polyBoundaryMesh::updateMesh where the
// is not done properly if I put it here. Something is not updated yet. // processor data is fully rebuilt. If this is not the case, the point
// VV, 31/Jan/2018. // level will remain unsynced and will cause all kinds of trouble that
// are extremely difficult to spot. See the change in
// polyTopoChanger::changeMesh order of calling polyMesh::updateMesh and
// polyTopoChanger::update. VV, 19/Feb/2019.
syncTools::syncPointList
(
mesh_,
newPointLevel,
maxEqOp<label>(),
0, // Null value
true // Apply separation for parallel cyclics
);
// Transfer the new point level into the data member // Transfer the new point level into the data member
pointLevel_.transfer(newPointLevel); pointLevel_.transfer(newPointLevel);

View file

@ -189,8 +189,8 @@ protected:
const label nei const label nei
) const; ) const;
//- Modifies existing faceI for either new owner/neighbour or new face //- Modifies existing faceI for either new owner/neighbour or new
// points. Reverses if nessecary // face points. Reverses if nessecary
void modifyFace void modifyFace
( (
polyTopoChange& ref, polyTopoChange& ref,

View file

@ -2490,10 +2490,14 @@ Foam::autoPtr<Foam::mapPolyMesh> Foam::polyTopoChanger::changeMesh()
topoChangeRequest()() topoChangeRequest()()
); );
update(topoChangeMap());
mesh_.updateMesh(topoChangeMap()); mesh_.updateMesh(topoChangeMap());
// Bugfix: call to polyTopoChanger::update must happen after
// polyMesh::updateMesh where all the relevant mesh bits for parallel
// comms are updated. First noticed when the syncying of pointLevel in
// refinement::updateMesh was syncying properly. VV, 19/Feb/2019
update(topoChangeMap());
// Increment the morph index // Increment the morph index
morphIndex_++; morphIndex_++;

View file

@ -89,7 +89,6 @@ void Foam::topoChangerFvMesh::insertFields
iter iter
) )
{ {
localFields[fI].set localFields[fI].set
( (
Pstream::myProcNo(), Pstream::myProcNo(),